From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5/qt5webengine: fix build error
Date: Tue, 30 Jul 2019 16:03:59 +0200 [thread overview]
Message-ID: <20190730160359.3f298606@windsurf> (raw)
In-Reply-To: <20190730115832.21008-1-b.bilas@grinn-global.com>
Hello Bartosz,
Thanks for your patch, see below for some questions.
On Tue, 30 Jul 2019 13:58:32 +0200
Bartosz Bilas <b.bilas@grinn-global.com> wrote:
> This commit adds a patch from upstream chromium
> and bumps required minimal gcc version to 8.
>
> Fixes:
> ../../3rdparty/chromium/third_party/skia/third_party/skcms/skcms.cc:1909:16:
> note: in definition of macro 'NS'
> #define NS(id) id
> ^~
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
Do we have any corresponding build failure in the autobuilders ? If so,
we like to have a reference to such build failures.
Also, why is the required gcc version now >= 8.x ? This is not really
explained in your commit log.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-07-30 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 11:58 [Buildroot] [PATCH] package/qt5/qt5webengine: fix build error Bartosz Bilas
2019-07-30 14:03 ` Thomas Petazzoni [this message]
2019-07-30 16:06 ` Bartosz Biłas
2019-07-30 21:30 ` Peter Seiderer
2019-07-31 7:15 ` Bartosz Biłas
2019-08-11 20:30 ` Thomas Petazzoni
2019-09-04 11:54 ` Andreas Naumann
2019-12-20 11:43 ` Giulio Benetti
2019-12-20 17:16 ` Bartosz Bilas
2020-04-01 15:03 ` Thomas Petazzoni
2020-04-02 5:35 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730160359.3f298606@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox