Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH v3 1/2] makedevs: only warn when xattr support disabled
Date: Tue, 30 Jul 2019 23:42:58 +0200	[thread overview]
Message-ID: <20190730214257.GC8530@dell5510> (raw)
In-Reply-To: <20190730205754.GH3194@scaer>

Hi Yann, others,

> Why do you want to exit in failure?

> When makedevs exits in error, then whole fakeroot script aborts even
> before attempting to generate the image.

> I can see two problems with that:

>   - first, when iputils is enabled, then the build will by default fail,
>     as xattr support is by default disabled,

>   - I can very well see a scenario where xattr, and thus capabilities,
>     are not desired. For example, if I need iputils, but will only ever
>     call clockdiff as root, then I don't care about its capabilities.

> So, I think it is nice that we warn that xattrs are dropped, but we
> should not fail the build.
Good point, I've sent v4 with this change.
Thanks for your review!

Regards to xattr support by default disabled, could you please have a look at
other my patch, which set default according to xattr support of used rootfs?
https://patchwork.ozlabs.org/project/buildroot/list/?series=120582

NOTE to reviewers: I've cleaned up previous versions in patchwork (set superseded)

Kind regards,
Petr

      reply	other threads:[~2019-07-30 21:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 20:31 [Buildroot] [RFC PATCH v3 1/2] makedevs: only warn when xattr support disabled Petr Vorel
2019-07-30 20:31 ` [Buildroot] [RFC PATCH v3 2/2] iputils: add capability for clockdiff, ping, traceroute6 Petr Vorel
2019-07-30 20:57 ` [Buildroot] [RFC PATCH v3 1/2] makedevs: only warn when xattr support disabled Yann E. MORIN
2019-07-30 21:42   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730214257.GC8530@dell5510 \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox