From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 1 Aug 2019 11:46:34 +0200 Subject: [Buildroot] [PATCH v3] package/libnss: use correct CFLAGS and LDFLAGS In-Reply-To: <93e84376-9b70-a3d4-422a-ceb3eadc71a6@micronovasrl.com> References: <20190729142610.21331-1-giulio.benetti@micronovasrl.com> <20190801005200.23317a95@windsurf.home> <93e84376-9b70-a3d4-422a-ceb3eadc71a6@micronovasrl.com> Message-ID: <20190801114634.193eca45@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Thu, 1 Aug 2019 11:12:09 +0200 Giulio Benetti wrote: > > So the proper fix is not to change the libnss > > code, and your patches are most likely going to be rejected upstream > > (with good reason). > > ...they have all been upstreamed: > https://hg.mozilla.org/projects/nss/log?rev=Giulio+Benetti > > They all have been discussed here: > https://bugzilla.mozilla.org/buglist.cgi?emailcc1=1&list_id=14831966&emaillongdesc1=1&emailtype1=exact&emailassigned_to1=1&short_desc_type=allwordssubstr&email1=giulio.benetti%40micronovasrl.com&emailbug_mentor1=1&emailreporter1=1&short_desc=Remove%20-Wmaybe-uninitialized%20warning&resolution=FIXED&classification=Client%20Software&classification=Developer%20Infrastructure&classification=Components&classification=Server%20Software&classification=Other&query_format=advanced&emailqa_contact1=1&product=NSS > > The first and more ambiguos warning was this: > https://bugzilla.mozilla.org/show_bug.cgi?id=1561548 > It sent me nut, not gcc :) > But in the end it was correct. I checked 3 of these (not all), and the three I checked were bogus, the variable was definitely initialized. > I'd say to keep as it is for the moment and when NSS_3_46 will be > released(soon) it will contain all patches we will remove > NSS_ENABLE_WERROR=0. > > What do you think? We generally disable Werror anyway in many packages, it's pretty common practice. It's common for new compiler versions to raise new warnings. Werror makes sense for upstream developers, a bit less so for downstream distributions/build-systems. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com