From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH buildroot-test 2/4] utils/daily-mail: allow to print a header for results section
Date: Thu, 1 Aug 2019 14:58:47 +0200 [thread overview]
Message-ID: <20190801145847.43d0aae8@windsurf.home> (raw)
In-Reply-To: <20190708081406.28215-3-victor.huesca@bootlin.com>
Hello,
On Mon, 8 Jul 2019 10:14:04 +0200
Victor Huesca <victor.huesca@bootlin.com> wrote:
> This table quite clear without header but as I had a template for the outdated
> table I also added the possibility to include one for results too.
>
> Note that this commit only add the option to print the header but does not
> enable it, so the existing behavior is preserved.
>
> Signed-off-by: Victor Huesca <victor.huesca@bootlin.com>
> ---
> utils/daily-mail | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/utils/daily-mail b/utils/daily-mail
> index 4ab7710..b4d0a56 100755
> --- a/utils/daily-mail
> +++ b/utils/daily-mail
> @@ -158,8 +158,25 @@ def add_outdated_pkg_notification(notifications, outdated_pkg):
> notif = get_notification_for_dev(notifications, get_orphan_developer())
> notif.package_version_notification.append(pkg)
>
> -def show_results(results, show_status, show_orphan=False):
> +
> +def show_results(results, show_status, show_orphan=False, show_header=False):
As I replied in my review of PATCH 1/4, please make this unconditional.
And this patch should come *before* the outdated package feature.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-08-01 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 8:14 [Buildroot] [PATCH buildroot-test 0/4] add support for outdated packages Victor Huesca
2019-07-08 8:14 ` [Buildroot] [PATCH buildroot-test 1/4] utils/daily-mail: add information about version that may need an update Victor Huesca
2019-08-01 12:57 ` Thomas Petazzoni
2019-07-08 8:14 ` [Buildroot] [PATCH buildroot-test 2/4] utils/daily-mail: allow to print a header for results section Victor Huesca
2019-08-01 12:58 ` Thomas Petazzoni [this message]
2019-07-08 8:14 ` [Buildroot] [PATCH buildroot-test 3/4] utils/daily-mail: add some debug information for the Notification class Victor Huesca
2019-08-01 12:59 ` Thomas Petazzoni
2019-07-08 8:14 ` [Buildroot] [PATCH buildroot-test 4/4] utils/daily-mail: add multiple argument to ease modularity of the script Victor Huesca
2019-08-01 13:01 ` Thomas Petazzoni
2019-08-01 12:42 ` [Buildroot] [PATCH buildroot-test 0/4] add support for outdated packages Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801145847.43d0aae8@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox