From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2 v7] package/iputils: drop setuid on arping
Date: Thu, 1 Aug 2019 19:25:28 +0200 [thread overview]
Message-ID: <20190801172527.GA27877@x230> (raw)
In-Reply-To: <f9b8b678e88316d6b572dc87e5080896cd8a84c7.1564676540.git.yann.morin.1998@free.fr>
Hi Yann,
> arping can be used for arp poisoning, so it should really not be setuid.
> Reported-by: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Acked-by: Petr Vorel <petr.vorel@gmail.com>
+1
> ---
> package/iputils/iputils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk
> index b28222138f..7482bbdca1 100644
> --- a/package/iputils/iputils.mk
> +++ b/package/iputils/iputils.mk
> @@ -80,7 +80,7 @@ IPUTILS_POST_INSTALL_TARGET_HOOKS += IPUTILS_CREATE_PING6_SYMLINK
> # handle permissions ourselves
> IPUTILS_CONF_OPTS += -DNO_SETCAP_OR_SUID=true
> define IPUTILS_PERMISSIONS
> - /usr/sbin/arping f 4755 0 0 - - - - -
> + /usr/sbin/arping f 755 0 0 - - - - -
> /usr/bin/clockdiff f 4755 0 0 - - - - -
> /bin/ping f 4755 0 0 - - - - -
> /usr/bin/traceroute6 f 4755 0 0 - - - - -
Kind regards,
Petr
next prev parent reply other threads:[~2019-08-01 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 16:22 [Buildroot] [PATCH 0/2 v7] package/iputils: use capabilties (branch yem/iputils-caps) Yann E. MORIN
2019-08-01 16:22 ` [Buildroot] [PATCH 1/2 v7] package/iputils: drop setuid on arping Yann E. MORIN
2019-08-01 17:25 ` Petr Vorel [this message]
2019-08-01 18:21 ` Peter Korsgaard
2019-08-01 16:22 ` [Buildroot] [PATCH 2/2 v7] package/iputils: use capabilities if possible Yann E. MORIN
2019-08-01 17:26 ` Petr Vorel
2019-08-01 18:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801172527.GA27877@x230 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox