From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 5/7] package/prboom: avoid using hardcoded optimization flags
Date: Sat, 3 Aug 2019 15:31:36 +0200 [thread overview]
Message-ID: <20190803153136.727eb902@windsurf.home> (raw)
In-Reply-To: <20190626125900.48230-6-giulio.benetti@micronovasrl.com>
On Wed, 26 Jun 2019 14:58:58 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> Package prboom builds using -O2 flag ignoring Buildroot settings, this
> is due to the fact that -O2 is appended at the end of compiler flags.
>
> Remove -O2 from 'configure.ac' file and set PRBOOM_AUTORECONF to YES,
> this way CFLAGS_OPTS will contain Buildroot TARGET_CFLAGS.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Your proposed solution is not ideal, because it really only prevents
prboom from adding -O2, but not any other option. A better solution
would have been to make sure that CFLAGS passed as ./configure
environment or arguments appear *after* the CFLAGS defined by the
configure.ac, so they can all be overridden. But well, that is too much
effort for a completely unmaintained piece of software, so I applied
your patch as-is.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-08-03 13:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 12:58 [Buildroot] [PATCH v2 0/7] Microblaze clean up Giulio Benetti
2019-06-26 12:58 ` [Buildroot] [PATCH v2 1/7] package/libnss: use correct CFLAGS and LDFLAGS Giulio Benetti
2019-06-26 13:02 ` Giulio Benetti
2019-06-26 12:58 ` [Buildroot] [PATCH v2 2/7] package/libnss: re-enable package on microblaze Giulio Benetti
2019-08-03 13:30 ` Thomas Petazzoni
2019-06-26 12:58 ` [Buildroot] [PATCH v2 3/7] package/ecryptfs-utils: remove libnss gcc bug dependency Giulio Benetti
2019-08-03 13:30 ` Thomas Petazzoni
2019-06-26 12:58 ` [Buildroot] [PATCH v2 4/7] package/boost: remove gcc bug 85180 dependency for boost-fiber option Giulio Benetti
2019-08-03 13:30 ` Thomas Petazzoni
2019-06-26 12:58 ` [Buildroot] [PATCH v2 5/7] package/prboom: avoid using hardcoded optimization flags Giulio Benetti
2019-08-03 13:31 ` Thomas Petazzoni [this message]
2019-08-30 20:28 ` Peter Korsgaard
2019-06-26 12:58 ` [Buildroot] [PATCH v2 6/7] package/prboom: work around gcc bug 85180 Giulio Benetti
2019-08-03 13:31 ` Thomas Petazzoni
2019-08-30 20:28 ` Peter Korsgaard
2019-06-26 12:59 ` [Buildroot] [PATCH v2 7/7] package/qt5/qt5webengine: re-enable building if BUG_85682=y on Qt5 Latest Giulio Benetti
2019-08-03 13:35 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190803153136.727eb902@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox