Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] busybox: Enable domain search list support in udhcpc
Date: Sat, 3 Aug 2019 17:49:00 +0200	[thread overview]
Message-ID: <20190803154900.GA26072@scaer> (raw)
In-Reply-To: <20190408110010.2596-1-abrodkin@synopsys.com>

Alexey, All,

On 2019-04-08 14:00 +0300, Alexey Brodkin spake thusly:
> This is useful in networks with internal resources as it allows
> to use much shorter names.
> 
> E.g. instead of "server.internal.company.com" it's possible
> to use just "server" if DHCP server is configured with:
> ---------------------------->8-----------------------
> option domain-search "internal.company.com";
> ---------------------------->8-----------------------
> 
> This improvement consists of 2 parts:
> 
> 1. Enable handling of RFC3397 so DHCP client is ready for processing
>    corresponding data from DHCP server.
> 
> 2. Some DHCP servers always send out search list if it is set in server's
>    configuration and some servers only provide search list if client
>    asks for that (sending list of options it expectes to get).
> 
>    And exactly for those stubborn DHCP servers we need to add "-O search"
>    to udhcp's command line via CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Ignacy Gawedzki <ignacy.gawedzki@green-communications.fr>
> Cc: Peter Korsgaard <peter@korsgaard.com>

Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/busybox/busybox.config | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config
> index 1d9560d655..ab04854c83 100644
> --- a/package/busybox/busybox.config
> +++ b/package/busybox/busybox.config
> @@ -967,9 +967,9 @@ CONFIG_UDHCPC_DEFAULT_SCRIPT="/usr/share/udhcpc/default.script"
>  # CONFIG_FEATURE_UDHCP_PORT is not set
>  CONFIG_UDHCP_DEBUG=0
>  CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS=80
> -# CONFIG_FEATURE_UDHCP_RFC3397 is not set
> +CONFIG_FEATURE_UDHCP_RFC3397=y
>  CONFIG_FEATURE_UDHCP_8021Q=y
> -CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-R -n"
> +CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-R -n -O search"
>  
>  #
>  # Print Utilities
> -- 
> 2.16.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2019-08-03 15:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 11:00 [Buildroot] [PATCH] busybox: Enable domain search list support in udhcpc Alexey Brodkin
2019-08-03 15:49 ` Yann E. MORIN [this message]
2019-08-03 16:03   ` Peter Korsgaard
2019-08-04  7:51     ` Alexey Brodkin
2019-08-30 20:32   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190803154900.GA26072@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox