Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/stellarium: new package
Date: Mon, 5 Aug 2019 22:42:21 +0200	[thread overview]
Message-ID: <20190805224221.763abc48@windsurf.home> (raw)
In-Reply-To: <ourk1gx4lk.ln2@ID-313208.user.individual.net>

Hello Bernd,

Thanks for your feedback!

On Mon, 05 Aug 2019 07:38:00 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> both BR2_PACKAGE_QT5SCRIPT and BR2_PACKAGE_QT5SERIALPORT are only 
> optional dependencies. My goal is to enable all available options in 
> Config.in.

Then, we should handle them like we normally do for optional
dependencies, with only the logic in the .mk file, and not selects in
the Config.in file.

> Regarding OpenGL ES I need to test this option, for now I only did build-
> tests using OpenGL so the package depends on BR2_PACKAGE_HAS_LIBGL for 

Could you add a comment in Config.in about this ?

If you fix those two minor nits, and resend an updated version, I think
we should be good to go.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-08-05 20:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 16:04 [Buildroot] [PATCH 1/1] package/stellarium: new package Bernd Kuhls
2019-08-04 22:07 ` Thomas Petazzoni
2019-08-05  5:38   ` Bernd Kuhls
2019-08-05 20:42     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190805224221.763abc48@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox