From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/5] autobuild-run: make diffoscope output a JSON-formatted file as well
Date: Tue, 13 Aug 2019 14:29:07 +0200 [thread overview]
Message-ID: <20190813142907.6d403904@windsurf.home> (raw)
In-Reply-To: <CABM+sgpWZQd0f9oReBXd=6Vjbj+E2OanQW8tEU_Dd-tR1qtpEg@mail.gmail.com>
Hello Atharva,
On Tue, 13 Aug 2019 09:37:27 +0530
Atharva Lele <itsatharva@gmail.com> wrote:
> > > + reproducible_results_text = os.path.join(self.outputdir, "results", "reproducible_results_text")
> >
>
> There's a typo here. Variable is named reproducible_results_txt in the
> patch, but in the diffoscope command I have used
> reproducible_results_text. I'll send a patch fixing this and the
> command consistency.
My bad. I initially started changing the variable names to something
more sensible, such as "diffoscope_results_json" and
"diffoscope_results_txt" and then changed my mind, as it should have
been a separate patch. But apparently, I undid my change incorrectly.
Sorry about this.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-08-13 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 3:58 [Buildroot] [PATCH v2 1/5] autobuild-run: use different output directories for reproducible builds testing Atharva Lele
2019-08-10 3:58 ` [Buildroot] [PATCH v2 2/5] autobuild-run: make prepare_build() clean the output directory used for reproducibility testing Atharva Lele
2019-08-11 13:39 ` Thomas Petazzoni
2019-08-10 3:59 ` [Buildroot] [PATCH v2 3/5] autobuild-run: make diffoscope output a JSON-formatted file as well Atharva Lele
2019-08-11 13:41 ` Thomas Petazzoni
2019-08-12 9:22 ` Atharva Lele
2019-08-13 4:07 ` Atharva Lele
2019-08-13 12:29 ` Thomas Petazzoni [this message]
2019-08-10 3:59 ` [Buildroot] [PATCH v2 4/5] autobuild-run: initial implementation of get_reproducibility_failure_reason() Atharva Lele
2019-08-10 3:59 ` [Buildroot] [PATCH v2 5/5] autobuild-run: account for reproducibility failures in get_failure_reason() Atharva Lele
2019-08-11 13:39 ` [Buildroot] [PATCH v2 1/5] autobuild-run: use different output directories for reproducible builds testing Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813142907.6d403904@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox