Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Atharva Lele <itsatharva@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] utils/br-reproduce-build: handle reproducibility failures
Date: Sun, 25 Aug 2019 23:06:35 +0530	[thread overview]
Message-ID: <20190825173635.23860-1-itsatharva@gmail.com> (raw)

Add a condition to check if the config has BR2_REPRODUCIBLE enabled and if it
does, run the build in two output directories - output-1, output-2 - and then
run diffoscope on the generated images.

NOTE: You should have diffoscope installed in order to test reproducibility
failures.

Signed-off-by: Atharva Lele <itsatharva@gmail.com>
---
 utils/br-reproduce-build | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/utils/br-reproduce-build b/utils/br-reproduce-build
index 592edc2..d8df3b2 100755
--- a/utils/br-reproduce-build
+++ b/utils/br-reproduce-build
@@ -76,7 +76,24 @@ if [ $? -ne 0 ] ; then
     exit 1
 fi
 
-mkdir ../output
-cp "${BUILD_DIR}/config" ../output/.config
-make olddefconfig O=../output/
-make 2>&1 O=../output | tee logfile
+# Handle cases of testing reproducibility failures.
+# Run the build in different output directories if BR2_REPRODUCIBLE=y
+# and run diffoscope on the generated images. Output of diffoscope is
+# saved in the "output-1" directory.
+# NOTE: You should have diffoscope installed in order to test
+# reproducibility failures.
+if grep -Fxq "BR2_REPRODUCIBLE=y" "${BUILD_DIR}/config"; then
+    mkdir ../output-1 ../output-2
+    cp "${BUILD_DIR}/config" ../output-1/.config
+    cp "${BUILD_DIR}/config" ../output-2/.config
+    make 2>&1 O=../output-1 | tee logfile && make 2>&1 O=../output-2 | tee logfile
+    PREFIX=$(make --no-print-directory O=../output-1 printvars VARS=TARGET_CROSS | cut -c 14- | head -c -1)
+    IMAGE_1="../output-1/images/rootfs.tar"
+    IMAGE_2="../output-2/images/rootfs.tar"
+    diffoscope ${IMAGE_1} ${IMAGE_2} --tool-prefix-binutils ${PREFIX} --text ../output-1/diffoscope_results.txt
+else
+    mkdir ../output
+    cp "${BUILD_DIR}/config" ../output/.config
+    make olddefconfig O=../output/
+    make 2>&1 O=../output | tee logfile
+fi
\ No newline at end of file
-- 
2.22.0

             reply	other threads:[~2019-08-25 17:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-25 17:36 Atharva Lele [this message]
2019-12-26 21:01 ` [Buildroot] [PATCH] utils/br-reproduce-build: handle reproducibility failures Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190825173635.23860-1-itsatharva@gmail.com \
    --to=itsatharva@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox