From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/pppd: use uclibc libcrypt instead of openssl
Date: Sat, 7 Sep 2019 21:48:30 +0200 [thread overview]
Message-ID: <20190907214830.37b71daa@windsurf> (raw)
In-Reply-To: <20190907183517.6176-1-alexander.i.mukhin@gmail.com>
On Sat, 7 Sep 2019 21:35:17 +0300
Alexander Mukhin <alexander.i.mukhin@gmail.com> wrote:
> glibc since 2.28 dropped DES encryption routines setkey() and encrypt(),
> but uclibc still provides them. So, if building with uclibc, we can
> avoid using huge openssl library.
>
> Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>
I've applied, after doing one small change, see below.
> +PPPD_MAKE_OPTS = HAVE_INET6=y
> +ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
> PPPD_DEPENDENCIES = openssl
I changed this to PPPD_DEPENDENCIES += instead of PPPD_DEPENDENCIES =.
Indeed, we're now in a conditional block, and we want to avoid
overwriting any PPPD_DEPENDENCIES assignment that could have been done
before that. There is none in the current pppd.mk, but one could be
added in the future, so we really like to use += to add conditional
dependencies.
Thanks for your contribution!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-09-07 19:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 10:18 [Buildroot] [PATCH] pppd: use uclibc libcrypt instead of openssl Alexander Mukhin
2019-09-06 11:35 ` Thomas Petazzoni
2019-09-06 11:49 ` Baruch Siach
2019-09-06 16:31 ` Alexander Mukhin
2019-09-07 12:32 ` Thomas Petazzoni
2019-09-07 18:35 ` [Buildroot] [PATCH] package/pppd: " Alexander Mukhin
2019-09-07 19:48 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907214830.37b71daa@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox