From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] support/dependencies/dependencies.sh: check for JSON:PP Perl module
Date: Tue, 17 Sep 2019 22:40:55 +0200 [thread overview]
Message-ID: <20190917224055.24d10f37@windsurf> (raw)
In-Reply-To: <20190915225743.88337-1-aperez@igalia.com>
Hello Adrian,
On Mon, 16 Sep 2019 01:57:43 +0300
Adrian Perez de Castro <aperez@igalia.com> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/faa23c0e648b916d0fb01adb95948234d6db7a71/
>
> The JSON::PP Perl module is used at build time by the webkitgtk
> and wpewebkit packages.
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
I've applied to master, thanks. However, I did a mistake: I deleted the
Fixes line and the URL, because I thought this patch would not fix the
build issue. Indeed, I thought that it if fails today when building
wpewebkit or webkitgtk, with your patch it would simply fail earlier in
the dependencies check.
However, as I wrote this explanation I realized that
utils/genrandconfig has some logic to check the dependencies and reject
a configuration if the necessary dependencies are not met.
So indeed, your patch fixes the above issue. Unfortunately, I had
already pushed the commit, so it was too late to re-amend the commit
log.
Sorry about that :-/
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-17 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 13:01 [Buildroot] [PATCH 1/1] package/webkitgtk: add missing host-perl dependency Adrian Perez de Castro
2019-09-15 13:54 ` François Perrad
2019-09-15 22:57 ` [Buildroot] [PATCH v2 1/1] support/dependencies/dependencies.sh: check for JSON:PP Perl module Adrian Perez de Castro
2019-09-17 20:40 ` Thomas Petazzoni [this message]
2019-09-26 9:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917224055.24d10f37@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox