Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [pkg-luarocks 3/6] pkg-luarocks: regen packages with external dependencies
Date: Thu, 19 Sep 2019 21:11:03 +0200	[thread overview]
Message-ID: <20190919211103.2057aa9a@windsurf> (raw)
In-Reply-To: <CAB0FRssGnc0G1XTb=SNEa=gONK42+L5gxife9QJQTS_P=v=SiQ@mail.gmail.com>

Hello Fran?ois,

On Thu, 19 Sep 2019 18:38:14 +0200
Fran?ois Perrad <francois.perrad@gadz.org> wrote:

> Previously, there is in the config file:
>     external_deps_dirs = { getenv('STAGING_DIR') .. [[/usr]] }
> and this path was globally used.
> 
> The config file is common for host-luarocks and luarocks,
> so this way is no longer doable.

We cannot pass a separate configuration file when building things for
the host and building things for the target ?

> `external_deps_dirs` has no equivalent as CLI option.
> But for each external dependency `BAR`, a CLI option `BAR_DIR` is available
> and must be set to `$(STAGING_DIR)/usr` (This is the LuaRocks way).
> 
> There are some explanations in the commit log 2/6.
> 
> If you look at the final point of the serie, the LuaRocks infrastructure is
> greatly improved:
>   - host-luarocks is now supported
>   - luarocks.mk contains no longer the cross-compilation stuff
>   - the macro _INSTALL_TARGET_CMDS in pkg-luarocks, contains all the
> cross-compilation stuff (better design compatible with per-package folders)
>   - luarocks is called without the full path of host-lua and without
> LUAROCKS_RUN_ENV

Don't get me wrong, I definitely agree that the series brings a number
of useful improvements. I just find it annoying that now all packages
need to pass a BAR_DIR = $(STAGING_DIR)/usr for all their native
dependencies, while it was not needed before. So that's why I'm asking
a few questions to see if we could do better.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-09-19 19:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18  6:19 [Buildroot] [pkg-luarocks 1/6] pkg-luarocks: remove LUAROCKS_RUN_ENV Francois Perrad
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 2/6] pkg-luarocks: refactor infra Francois Perrad
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 3/6] pkg-luarocks: regen packages with external dependencies Francois Perrad
2019-09-18  7:35   ` Thomas Petazzoni
2019-09-18 18:19     ` François Perrad
2019-09-18 19:16       ` Thomas Petazzoni
2019-09-19 16:38         ` François Perrad
2019-09-19 19:11           ` Thomas Petazzoni [this message]
2020-03-20 21:41           ` Thomas Petazzoni
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 4/6] pkg-luarocks: add support of host-luarocks-package Francois Perrad
2020-03-20 21:48   ` Thomas Petazzoni
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 5/6] package/lua: allows to load native modules from host-lua Francois Perrad
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 6/6] package/lua: allows host-lua to find installed modules Francois Perrad
2019-09-18  7:31 ` [Buildroot] [pkg-luarocks 1/6] pkg-luarocks: remove LUAROCKS_RUN_ENV Thomas Petazzoni
2019-09-18 18:18   ` François Perrad
2020-03-20 21:40     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919211103.2057aa9a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox