Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit branch/2019.02.x] qt5base: Add patch to fix compile issue with gcc9
Date: Thu, 19 Sep 2019 21:48:12 +0200	[thread overview]
Message-ID: <20190919214812.6f719f06@windsurf> (raw)
In-Reply-To: <24a3771b-2bf4-66a7-2b84-13eeb87488c3@orolia.com>

On Thu, 19 Sep 2019 16:07:33 +0000
Julien B?raud <julien.beraud@orolia.com> wrote:

> On 19/09/2019 17:26, Peter Korsgaard wrote:
> >>>>>> "Julien" == Julien B?raud <julien.beraud@orolia.com> writes:  
> >   
> >   > Backport:
> >   > https://github.com/qt/qtbase/commit/a52d7861edfb5956de38ba80015c4dd0b596259b#diff-0b4819f9df9c43297ba840d1ac401599
> >   > Signed-off-by: Julien Beraud <julien.beraud@orolia.com>  
> > 
> > Ehh, I got a bit confused first as this looked like a git commit
> > notification.  
> 
> Sorry I am just referring to the commit in the upstream project

That's not what Peter is talking about. He is talking about the prefix
of your patch. Normally, patches are like this:

 [PATCH] package/qt5base: something

or:

 [PATCH 2019.02.x] package/qt5base: something

But you sent it as:

 [git commit branch/2019.02.x] ...

If you look at the mailing list traffic, e-mails prefixed with [PATCH]
are actual patches submitted by contributors, while e-mails prefixed
with [git commit] are auto-generated e-mails that get sent when the
Buildroot maintainers merge some patches and push them as commits to
the official Git repo.

Hence, your patch was quite confusing, because its title prefix looked
like a Git commit notification.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-09-19 19:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19  7:36 [Buildroot] [git commit branch/2019.02.x] qt5base: Add patch to fix compile issue with gcc9 Julien Béraud
2019-09-19 15:26 ` Peter Korsgaard
2019-09-19 16:07   ` Julien Béraud
2019-09-19 16:46     ` Peter Korsgaard
2019-09-20  8:26       ` Julien Béraud
2019-09-19 19:48     ` Thomas Petazzoni [this message]
2019-09-20  7:50       ` Julien Béraud
2019-09-20  7:53         ` Thomas Petazzoni
2019-09-20  8:02           ` Julien Béraud
2019-09-19 19:49 ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2019-10-01 21:49 Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919214812.6f719f06@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox