From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] arch/riscv: set the default float ABI based on ISA extensions
Date: Thu, 19 Sep 2019 21:51:01 +0200 [thread overview]
Message-ID: <20190919215101.6c2944d1@windsurf> (raw)
In-Reply-To: <20190919154036.23245-1-mark.corbin@embecosm.com>
Hello Mark,
On Thu, 19 Sep 2019 16:40:35 +0100
Mark Corbin <mark.corbin@embecosm.com> wrote:
> This patch sets the default floating point ABI based on the ISA
> extensions that have been selected rather than defaulting to soft
> float.
>
> For 64-bit:
>
> ISA 'D' selects lp64d
> ISA 'F' selects lp64f
> Otherwise select lp64
>
> For 32-bit:
>
> ISA 'D' selects ilp32d
> ISA 'F' selects ilp32f
> Otherwise select ilp32
>
> This change was proposed by Palmer Dabbelt at SiFive.
>
> Signed-off-by: Mark Corbin <mark.corbin@embecosm.com>
> Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
> ---
> arch/Config.in.riscv | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied to master, thanks. However, I'm wondering: does it really makes
sense to offer a choice of the ABI ? Would there be a reason for a user
to use lp64 if he has the D ISA for example ? It would seem logical to
simply use lp64d as soon as you have the D ISA.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-09-19 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 15:40 [Buildroot] [PATCH 1/1] arch/riscv: set the default float ABI based on ISA extensions Mark Corbin
2019-09-19 19:51 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919215101.6c2944d1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox