From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] package/python-colorlog: new package
Date: Thu, 19 Sep 2019 23:25:28 +0200 [thread overview]
Message-ID: <20190919232528.600e99cb@windsurf> (raw)
In-Reply-To: <20190916115504.8575-1-offougajoris@gmail.com>
Hello,
On Mon, 16 Sep 2019 13:55:03 +0200
Joris Offouga <offougajoris@gmail.com> wrote:
> Colorlog is a formatter for the python logging module.
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Thanks for your contribution, I've applied to master.
Two minor things that would have made this patch perfect:
- The two patches for python-colorlog and python-simplelogging should
have always been sent together. Even if only one of the two has
changes, always send a new iteration of both patches. Otherwise,
it's unclear that they are related, and depend on each other.
- In the DEVELOPERS file, the entries end with a slash, i.e
package/python-colorlog/ and not package/python-colorlog
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-19 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 11:55 [Buildroot] [PATCH v3 1/2] package/python-colorlog: new package Joris Offouga
2019-09-19 21:25 ` Thomas Petazzoni [this message]
2019-09-19 21:29 ` Joris OFFOUGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919232528.600e99cb@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox