From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] package/python-kiwisolver: new package
Date: Thu, 19 Sep 2019 23:54:37 +0200 [thread overview]
Message-ID: <20190919235437.3630bff6@windsurf> (raw)
In-Reply-To: <20190917085034.2509-1-esben@geanix.com>
Hello,
On Tue, 17 Sep 2019 10:50:33 +0200
Esben Haabendal <esben@geanix.com> wrote:
> +config BR2_PACKAGE_PYTHON_KIWISOLVER
> + bool "python-kiwisolver"
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON
a dependency on python || python is not very useful, especially since
anyway this Config.in is already included in a python || python3
condition.
> diff --git a/package/python-kiwisolver/python-kiwisolver.mk b/package/python-kiwisolver/python-kiwisolver.mk
> new file mode 100644
> index 000000000000..96019fc29328
> --- /dev/null
> +++ b/package/python-kiwisolver/python-kiwisolver.mk
> @@ -0,0 +1,7 @@
You forgot our completely useless, but absolutely mandatory and lovely
comment header that we have in all packages.
I fixed both issues and applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-19 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 8:50 [Buildroot] [PATCH v3 1/2] package/python-kiwisolver: new package Esben Haabendal
2019-09-17 8:50 ` [Buildroot] [PATCH v3 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
2019-09-30 20:11 ` Thomas Petazzoni
2019-09-17 9:09 ` [Buildroot] [PATCH v3 1/2] package/python-kiwisolver: new package Yegor Yefremov
2019-09-17 12:20 ` Esben Haabendal
2019-09-19 21:54 ` Thomas Petazzoni [this message]
2019-09-20 4:40 ` Esben Haabendal
2019-09-20 7:29 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919235437.3630bff6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox