From: Norbert Lange <nolange79@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/systemd: fix build not adding stack protector library
Date: Fri, 20 Sep 2019 10:53:14 +0200 [thread overview]
Message-ID: <20190920085314.7816-1-nolange79@gmail.com> (raw)
the stack protector flag is added during compilation,
but not when linking. A compiler not defaulting to ssp
will complain about missing symbols
upstream PR #13599
Signed-off-by: Norbert Lange <nolange79@gmail.com>
---
...ompilers-with-default-stack-protecto.patch | 31 +++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 package/systemd/0005-fix-build-with-compilers-with-default-stack-protecto.patch
diff --git a/package/systemd/0005-fix-build-with-compilers-with-default-stack-protecto.patch b/package/systemd/0005-fix-build-with-compilers-with-default-stack-protecto.patch
new file mode 100644
index 0000000000..d233df90da
--- /dev/null
+++ b/package/systemd/0005-fix-build-with-compilers-with-default-stack-protecto.patch
@@ -0,0 +1,31 @@
+From e028863a2ed4b380e12a79479fc7fc13d7b3214a Mon Sep 17 00:00:00 2001
+From: Norbert Lange <nolange79@gmail.com>
+Date: Thu, 19 Sep 2019 17:49:20 +0200
+Subject: [PATCH] fix build with compilers with default stack-protector enabled
+
+building systemd fails with a compiler that supports
+-fstack-protector but does not enable it by default.
+(will miss several __stack_chk_* symbols).
+
+fix this by also adding the switch during linking.
+
+Signed-off-by: Norbert Lange <nolange79@gmail.com>
+---
+ meson.build | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/meson.build b/meson.build
+index e5ceb1e..4fc7dfa 100644
+--- a/meson.build
++++ b/meson.build
+@@ -382,6 +382,7 @@ possible_cc_flags = [
+ possible_link_flags = [
+ '-Wl,-z,relro',
+ '-Wl,-z,now',
++ '-fstack-protector',
+ ]
+
+ if cc.get_id() == 'clang'
+--
+2.23.0
+
--
2.23.0
next reply other threads:[~2019-09-20 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 8:53 Norbert Lange [this message]
2019-11-08 21:22 ` [Buildroot] [PATCH 1/1] package/systemd: fix build not adding stack protector library Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920085314.7816-1-nolange79@gmail.com \
--to=nolange79@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox