From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] support/scripts/genimage.sh: allow setting rootpath from parameters.
Date: Sun, 22 Sep 2019 09:01:24 +0200 [thread overview]
Message-ID: <20190922090124.752d63c2@windsurf.home> (raw)
In-Reply-To: <CAJ4jsaeV46L0mCiZH2zVq4c8d9CNLasOKRHEP-yTaiAc6h7c7g@mail.gmail.com>
On Sat, 21 Sep 2019 21:55:19 -0300
Carlos Santos <unixmania@gmail.com> wrote:
> Currently there are thirty board/*/post-image.sh files. Twenty of them
> are variants of genimage.sh and three of them call it so I believe
> that a more versatile genimage.sh would reduce some code duplication.
I believe plenty of those post-image.sh predate the time we had
genimage.sh and could simply be converted to use it, without changes to
genimage.sh.
For the remaining cases that need special things not provided by
genimage.sh, I don't see the point of replicating all the options of
the genimage tool in genimage.sh: in that case you'd better call
genimage directly. It would just seem to be an extra layer that doesn't
bring anything useful.
As usual, this is just a personal opinion, and others can disagree, and
I will not strongly oppose as what I'm exposing here is a weak feeling.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-22 7:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 12:09 [Buildroot] [PATCH 1/1] support/scripts/genimage.sh: allow setting rootpath from parameters raphael.melotte at essensium.com
2019-09-18 8:42 ` Thomas Petazzoni
2019-09-22 0:55 ` Carlos Santos
2019-09-22 7:01 ` Thomas Petazzoni [this message]
2019-09-23 7:44 ` Raphaël Mélotte
2019-09-23 7:55 ` Arnout Vandecappelle
2020-01-06 20:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190922090124.752d63c2@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox