Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: generate check-headers program under $(BUILD_DIR)
Date: Mon, 23 Sep 2019 13:48:18 +0200	[thread overview]
Message-ID: <20190923134818.0dc51b3f@windsurf> (raw)
In-Reply-To: <CAJ4jsadbeyaFRcSYUWsBvTqAOCHQEhipQ8R4V31Hp8F29QdFVQ@mail.gmail.com>

On Mon, 23 Sep 2019 08:17:55 -0300
Carlos Santos <unixmania@gmail.com> wrote:

> > I'm rather surprised that check-headers is the nly thing broken in that
> > case... :-/
> >
> > Alternatively, we should probably use our own TMPDIR instead, which
> > would fix all such problems:
> >
> >     diff --git a/Makefile b/Makefile
> >     index 82c844620a..a006149898 100644
> >     --- a/Makefile
> >     +++ b/Makefile
> >     @@ -209,6 +209,11 @@ BASE_TARGET_DIR := $(BASE_DIR)/target
> >      HOST_DIR := $(BASE_DIR)/host
> >      GRAPHS_DIR := $(BASE_DIR)/graphs
> >
> >     +export TMPDIR = $(BUILD_DIR)/.br-temp-or-whatever
> >     +export TMP_DIR = $(TMPDIR)
> >     +export TEMP_DIR = $(TMPDIR)
> >     +# And so on...  
> 
> That would create all temporary files under
> $(BUILD_DIR)/.br-temp-or-whatever, ruining the advantage of using a
> tmpfs mounted at /tmp, which is much faster because it's in RAM.

The problem indeed only occurs with temporary files that need to be
*executed*. For example, gcc creates tons of temporary files in /tmp,
and that works perfectly fine and shouldn't be changed. So at this
point, I also tend to prefer Carlos solution to only address the
check-headers case.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-09-23 11:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23  1:05 [Buildroot] [PATCH] toolchain: generate check-headers program under $(BUILD_DIR) unixmania at gmail.com
2019-09-23  8:38 ` yann.morin at orange.com
2019-09-23 11:17   ` Carlos Santos
2019-09-23 11:48     ` Thomas Petazzoni [this message]
2019-09-23 12:04     ` yann.morin at orange.com
2019-09-23 12:08       ` Thomas Petazzoni
2019-09-23 12:19       ` Carlos Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190923134818.0dc51b3f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox