From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 24 Sep 2019 09:47:36 +0200 Subject: [Buildroot] [PATCH] libhttpserver: new package In-Reply-To: References: <20190923115237.4524-1-stephan.hoffmann@ext.grandcentrix.net> <20190923155623.711a3539@windsurf> Message-ID: <20190924094736.7e1530f7@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Tue, 24 Sep 2019 09:22:37 +0200 Stephan Hoffmann wrote: > > We need a Signed-off-by line (at least from you) in this patch. Also, > > if it comes from upstream, a link to the upstream commit is good to > > have. > > > Is there any mechanism allowing to cherry pick a commit from the upstream > repo instead of providing a patch file? I don't really feel good about > modifying the patch file;-) We prefer to have patches locally instead of downloading them, because the hash of patches generated by Github is not stable. We have numerous patches locally in package directories, and changing their commit log is perfectly fine. See for example package/fastd/0003-cipher-remove-aes128-ctr-NaCl-implementation.patch how the Signed-off-by line and reference to the upstream commit was added. Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com