Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/php-xdebug: new package
Date: Wed, 25 Sep 2019 14:02:19 +0200	[thread overview]
Message-ID: <20190925140219.1a0681ef@windsurf> (raw)
In-Reply-To: <f24884d9b449983b9630d2a5ab43823ec586affa.camel@orolia.com>

Hello,

On Wed, 25 Sep 2019 12:00:19 +0000
Nicolas Carrier <nicolas.carrier@orolia.com> wrote:

> I tried to address all your comments, but:
>  * I didn't manage to use test-pkg, I ran:
>        ./utils/test-pkg -p php-xdebug -c php-xdebug.config
>    but only got a bunch of [...] SKIPPED messages
>    (same with -a).
>    php-xdebug.config's content was:
>        BR2_PACKAGE_PHP_XDEBUG=y

You also need:

BR2_PACKAGE_PHP=y

Because PHP_XDEBUG=y has a depends on BR2_PACKAGE_PHP, if you don't
also enable BR2_PACKAGE_PHP in your config fragment,
BR2_PACKAGE_PHP_XDEBUG=y will be discarded as it has an unmet
dependency.

>  * I didn't manage either to use check-package. I ran:
>        $ ./utils/check-package package/php-xdebug/*
>    _before_ fixing the two errors Arnout mentioned in the Config.in,
>    but just got:
>        36 lines processed
>        0 warnings generated

Well, 36 lines were processed, and no warnings were generated, so
you're all good.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-09-25 12:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 11:45 [Buildroot] [PATCH v2 1/1] package/php-xdebug: new package Nicolas Carrier
2019-09-25 12:00 ` Nicolas Carrier
2019-09-25 12:02   ` Thomas Petazzoni [this message]
2019-09-25 12:37     ` Nicolas Carrier
2019-09-25 13:02   ` Arnout Vandecappelle
2019-10-02 10:31     ` Nicolas Carrier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190925140219.1a0681ef@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox