From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Revert "package/mesa3d: add OSMesa classic needs dri swrast"
Date: Wed, 25 Sep 2019 21:53:40 +0200 [thread overview]
Message-ID: <20190925215340.74b53775@windsurf> (raw)
In-Reply-To: <20190925191716.GE7274@scaer>
On Wed, 25 Sep 2019 21:17:16 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> A revert is when a commit was faulty. But 1ad2c7f6 was not faulty : it
> properly accounted for a limitation of the upstream package.
>
> However, it is the bump to a newer mesa3d version that allows to relax
> the condition now that upstream has lifted their limitation.
>
> As such, IMHO, this patch should either:
>
> - be squashed with the previous one, keeping the link to the
> upstream commit (which is very nice of you to provide!),
>
> - or be kept in a separate patch, but not identified as a revert.
>
> I would favour the first option.
Agreed.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-09-25 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 19:05 [Buildroot] [PATCH 1/2] package/mesa3d: bump version to 19.2.0 Bernd Kuhls
2019-09-25 19:05 ` [Buildroot] [PATCH 2/2] Revert "package/mesa3d: add OSMesa classic needs dri swrast" Bernd Kuhls
2019-09-25 19:17 ` Yann E. MORIN
2019-09-25 19:53 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925215340.74b53775@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox