From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: rename variable 'm'
Date: Wed, 25 Sep 2019 22:26:31 +0200 [thread overview]
Message-ID: <20190925222631.5fc62fea@windsurf> (raw)
In-Reply-To: <20190903211341.10341-1-jerzy.m.grzegorek@gmail.com>
Hello,
On Tue, 3 Sep 2019 23:13:24 +0200
Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com> wrote:
> Rename variable 'm' for better readability.
>
> Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> utils/checkpackagelib/lib_config.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
I have applied patches 1 to 5 (included), with Ricardo Acked-by, after
fixing PATCH 02/18 to initialize self.level, and also taking into
account the other comments made by Ricardo on the commit titles and
commit logs.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-09-25 20:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 21:13 [Buildroot] [PATCH 01/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: rename variable 'm' Jerzy Grzegorek
2019-09-03 21:13 ` [Buildroot] [PATCH 02/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: change the type of variable 'level' Jerzy Grzegorek
2019-09-25 2:03 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 03/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: get value " Jerzy Grzegorek
2019-09-25 2:05 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 04/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: add functions to initialize arrays elements Jerzy Grzegorek
2019-09-25 2:07 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 05/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: change the type of variable 'new_package' Jerzy Grzegorek
2019-09-25 2:08 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 06/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: remove '-comment' state before the '-menu' one Jerzy Grzegorek
2019-10-04 2:27 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 07/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: separate the lines support Jerzy Grzegorek
2019-10-04 2:27 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 08/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: use '-' to describe state Jerzy Grzegorek
2019-09-03 21:13 ` [Buildroot] [PATCH 09/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: drop function get_line Jerzy Grzegorek
2019-10-04 2:28 ` Ricardo Martincoski
2019-10-04 6:52 ` Jerzy Grzegorek
2019-09-03 21:13 ` [Buildroot] [PATCH 10/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: initialize 'menu_of_packages' array Jerzy Grzegorek
2019-10-04 2:28 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 11/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: add more Config.in files to check Jerzy Grzegorek
2019-10-04 2:29 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 12/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: check package ordering just before 'if ' statement Jerzy Grzegorek
2019-09-03 21:13 ` [Buildroot] [PATCH 13/18] package/Config.in: fix packages ordering Jerzy Grzegorek
2019-09-03 21:13 ` [Buildroot] [PATCH 14/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: check the order of comments menu Jerzy Grzegorek
2019-09-25 2:14 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 15/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: check the order of menu of menus Jerzy Grzegorek
2019-09-25 2:19 ` Ricardo Martincoski
2019-09-25 8:01 ` Jerzy Grzegorek
2019-10-04 2:26 ` Ricardo Martincoski
2019-09-03 21:13 ` [Buildroot] [PATCH 16/18] package/Config.in: fix menus ordering Jerzy Grzegorek
2019-09-03 21:13 ` [Buildroot] [PATCH 17/18] package/kodi/Config.in: " Jerzy Grzegorek
2019-09-03 21:13 ` [Buildroot] [PATCH 18/18] " Jerzy Grzegorek
2019-09-23 21:17 ` [Buildroot] [PATCH 01/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: rename variable 'm' Thomas Petazzoni
2019-09-24 2:28 ` Ricardo Martincoski
2019-09-24 2:32 ` Ricardo Martincoski
2019-09-25 20:26 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925222631.5fc62fea@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox