From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libssh: add option to enable server support
Date: Fri, 27 Sep 2019 23:02:12 +0200 [thread overview]
Message-ID: <20190927230212.2ed06bd6@windsurf> (raw)
In-Reply-To: <20190925121726.17454-1-heiko.thiery@gmail.com>
Hello,
Thanks for your contribution!
On Wed, 25 Sep 2019 14:17:26 +0200
heiko.thiery at gmail.com wrote:
> +ifeq ($(BR2_PACKAGE_LIBSSH_SERVER),y)
> + LIBSSH_CONF_OPTS += -DWITH_SERVER=ON
> +else
> + LIBSSH_CONF_OPTS += -DWITH_SERVER=OFF
We don't indent such lines in our coding style, as can be seen in the
rest of the file. I have fixed this and applied your patch to Buildroot
master branch.
Just curious, what is the use case for the server support in libssh ?
The INSTALL file is not very clear about what WITH_SERVER=ON provides.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-27 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:17 [Buildroot] [PATCH 1/1] package/libssh: add option to enable server support heiko.thiery at gmail.com
2019-09-27 21:02 ` Thomas Petazzoni [this message]
2019-09-28 7:27 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927230212.2ed06bd6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox