From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/1] package/libsodium: add config for full build
Date: Sun, 29 Sep 2019 09:04:08 +0200 [thread overview]
Message-ID: <20190929090408.67e6d38e@windsurf> (raw)
In-Reply-To: <CAFtSRGDT0udQCby-XzsZTe-VUTBSva7cdrh6wpZ_nMf+J8Pz2Q@mail.gmail.com>
On Sat, 28 Sep 2019 23:49:56 +0200
Adrien Gallou?t <adrien@gallouet.fr> wrote:
> > But then, does it make sense to invert the option and name it
> > BR2_PACKAGE_LIBSODIUM_MINIMAL ? It would match the
> > --enable-minimal/--disable-minimal autoconf options of libsodium.
>
> That was my first patch :) Do you want me to resubmit it ?
I don't have a very clear-cut opinion.
On one hand, it is weird to have a Config.in option to reduce/remove
something. But on the other hand, it makes sense to have Config.in
options that are as much as possible mapped to the corresponding
options provided by the package build system.
Arnout, Peter, any preference ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-29 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:29 [Buildroot] [PATCH v4 1/1] package/libsodium: add config for full build Adrien Gallouët
2019-09-28 21:19 ` Thomas Petazzoni
2019-09-28 21:49 ` Adrien Gallouët
2019-09-29 7:04 ` Thomas Petazzoni [this message]
2019-09-29 10:51 ` Arnout Vandecappelle
2019-09-30 12:04 ` Peter Korsgaard
2019-09-30 12:29 ` Thomas Petazzoni
2019-10-24 8:30 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190929090408.67e6d38e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox