Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/08] package/python-aioredis: new package
Date: Mon, 30 Sep 2019 21:43:26 +0200	[thread overview]
Message-ID: <20190930214326.08b36939@windsurf.home> (raw)
In-Reply-To: <20190804011631.86261-7-aduskett@gmail.com>

Hello,

On Sat,  3 Aug 2019 21:16:29 -0400
aduskett at gmail.com wrote:

> diff --git a/package/python-aioredis/Config.in b/package/python-aioredis/Config.in
> new file mode 100644
> index 0000000000..aa410dc9a7
> --- /dev/null
> +++ b/package/python-aioredis/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_PYTHON_AIOREDIS
> +	bool "python-aioredis"
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC # redis
> +	select BR2_PACKAGE_PYTHON_ASYNC_TIMEOUT # runtime
> +	select BR2_PACKAGE_PYTHON_HIREDIS # runtime
> +	select BR2_PACKAGE_REDIS # runtime

There is no need to select BR2_PACKAGE_REDIS, the redis server could be
a remote one, so it may not be hosted on the same machine as the one
running python-aioredis.

However, you were missing a BR2_PACKAGE_PYTHON3 dependency, because
python-aioredis only works with python 3.x.

> +comment "python-aioredis needs a toolchain w/ atomic"
> +	depends on !BR2_TOOLCHAIN_HAS_ATOMIC

This is no longer relevant due to the redis select removal, but for the
record, we don't add Config.in comments for toolchain atomics, because
there is nothing the user can do about it.

I've applied your patch with the redis dependency dropped, and the
addition of a python3 dependency.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-09-30 19:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04  1:16 [Buildroot] [PATCH 00/13] Support for Django channels aduskett at gmail.com
2019-08-04  1:16 ` [Buildroot] [PATCH 01/08] package/python-django-enumfields: new package aduskett at gmail.com
2019-09-27 21:41   ` Thomas Petazzoni
2019-08-04  1:16 ` [Buildroot] [PATCH 02/08] package/python-sqlparse: " aduskett at gmail.com
2019-09-27 21:49   ` Thomas Petazzoni
2019-08-04  1:16 ` [Buildroot] [PATCH 03/08] package/python-hiredis: " aduskett at gmail.com
2019-08-04  5:53   ` Yegor Yefremov
2019-08-04 10:18   ` Peter Korsgaard
2019-08-04  1:16 ` [Buildroot] [PATCH 04/08] package/python-daphne: " aduskett at gmail.com
2019-08-04  5:58   ` Yegor Yefremov
2019-09-30 19:33   ` Thomas Petazzoni
2019-09-30 19:58     ` Thomas Petazzoni
2019-08-04  1:16 ` [Buildroot] [PATCH 05/08] package/python-asgiref: " aduskett at gmail.com
2019-09-27 21:55   ` Thomas Petazzoni
2019-08-04  1:16 ` [Buildroot] [PATCH 06/08] package/python-aioredis: " aduskett at gmail.com
2019-09-30 19:43   ` Thomas Petazzoni [this message]
2019-08-04  1:16 ` [Buildroot] [PATCH 07/08] package/python-channels: " aduskett at gmail.com
2019-09-30 19:58   ` Thomas Petazzoni
2019-08-04  1:16 ` [Buildroot] [PATCH 08/08] package/python-channels-redis: " aduskett at gmail.com
2019-09-30 20:09   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190930214326.08b36939@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox