Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] cmake: bump version to 3.15.3
Date: Tue, 1 Oct 2019 08:58:32 +0200	[thread overview]
Message-ID: <20191001085832.6d748766@windsurf.home> (raw)
In-Reply-To: <CADvTj4qO6FZYmjgP2GBLcrf7P-k14JCz2jVvcTrFT4B1Tt5dbQ@mail.gmail.com>

On Tue, 1 Oct 2019 00:38:47 +0200
James Hilliard <james.hilliard1@gmail.com> wrote:

> > What is the reasoning for changing the minimal CMake version to 3.10 ?
> >  
> It's the minimum required by wpewebkit.

OK, but it's totally unrelated to the bump of CMake.

> > This minimum version is the minimum version required by all
> > cmake-package packages in Buildroot, and is important when the
> > system-provided cmake is used as opposed to using Buildroot's
> > host-cmake. So I don't see how it can be related to a version bump of
> > CMake.
> >
> > The second question is how many cmake-package packages you have tested
> > with this patch applied ? We don't need all of them to be tested, but
> > it would be good to test a fair amount of them, and provide in the
> > commit log the defconfig that was used to test all those packages.
>
> Not entirely sure but was probably a decent amount as part of my normal
> firmware builds.

Would be good to give a sense of how many packages where tested. It's
just that from our experience, bumping the packages implementing a
build system (cmake, meson, etc.) tend to break quite a bit of stuff,
and a 3.8 -> 3.15 bump is quite significant for cmake.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-10-01  6:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29 11:57 [Buildroot] [PATCH v2 1/1] cmake: bump version to 3.15.3 James Hilliard
2019-09-30  8:59 ` Adrian Perez de Castro
2019-09-30 21:35 ` Thomas Petazzoni
2019-09-30 22:38   ` James Hilliard
2019-09-30 23:52     ` Adrian Perez de Castro
2019-10-01  6:58     ` Thomas Petazzoni [this message]
2019-10-01  7:06       ` James Hilliard
2019-10-01  8:43   ` Arnout Vandecappelle
2019-10-01 10:31     ` yann.morin at orange.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191001085832.6d748766@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox