From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/brltty: fix build with expat
Date: Sat, 5 Oct 2019 22:37:47 +0200 [thread overview]
Message-ID: <20191005223747.4cdc2ee9@windsurf> (raw)
In-Reply-To: <CAPi7W81GM5+T7iaqAFajZzjn_NWVLQfi=z8vGxpGAU67KX7M4w@mail.gmail.com>
On Tue, 1 Oct 2019 08:42:24 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Maybe it's because it's late and I'm no longer thinking properly, but
> > do you understand how disabling expat prevents the cldr program from
> > being built, and therefore the tbl2hex utility tool from being built ?
> > They seem to be unconditionally built by Programs/Makefile.in.
> cldr.c is mostly an empty shell without expat as most of the code is
> protected by ifdef HAVE_EXPAT blocks, see
> https://github.com/brltty/brltty/blob/aba3d8cc2dc765a0933aabb609928e568e085d39/Programs/cldr.c.
OK, but where is the logic that links with -lexpat when it's available,
and doesn't link with -lexpat when not available ? I'm a bit confused
by the build logic of this package I must say.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-05 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 8:40 [Buildroot] [PATCH 1/1] package/brltty: fix build with expat Fabrice Fontaine
2019-09-30 21:46 ` Thomas Petazzoni
2019-10-01 6:42 ` Fabrice Fontaine
2019-10-05 20:37 ` Thomas Petazzoni [this message]
2019-10-09 17:16 ` Fabrice Fontaine
2019-10-12 19:58 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2020-02-14 16:40 Fabrice Fontaine
2020-02-19 23:44 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005223747.4cdc2ee9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox