From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/nbd: add host-pkgconf to dependencies
Date: Sun, 6 Oct 2019 17:14:24 +0200 [thread overview]
Message-ID: <20191006151424.GM10860@scaer> (raw)
In-Reply-To: <20191006084912.10456-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2019-10-06 10:49 +0200, Fabrice Fontaine spake thusly:
> pkg-config is used to find libglib2 since version 3.17 and
> https://github.com/NetworkBlockDevice/nbd/commit/ef86bbd9da2e2116ec0da6f9c130fb52e89fc310
I was wondering why we had no build issue due to this, but nbd depends
on libglib2, and libglib2 already depends on host-pkgconf, so this was a
hidden dependency.
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/nbd/nbd.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/nbd/nbd.mk b/package/nbd/nbd.mk
> index 484f3e695b..fa569f3224 100644
> --- a/package/nbd/nbd.mk
> +++ b/package/nbd/nbd.mk
> @@ -8,7 +8,7 @@ NBD_VERSION = 3.19
> NBD_SOURCE = nbd-$(NBD_VERSION).tar.xz
> NBD_SITE = http://downloads.sourceforge.net/project/nbd/nbd/$(NBD_VERSION)
> NBD_CONF_OPTS = --enable-lfs
> -NBD_DEPENDENCIES = libglib2
> +NBD_DEPENDENCIES = host-pkgconf libglib2
> NBD_LICENSE = GPL-2.0
> NBD_LICENSE_FILES = COPYING
>
> --
> 2.23.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-10-06 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 8:49 [Buildroot] [PATCH 1/2] package/nbd: add host-pkgconf to dependencies Fabrice Fontaine
2019-10-06 8:49 ` [Buildroot] [PATCH 2/2] package/nbd: bump to version 3.20 Fabrice Fontaine
2019-10-06 15:20 ` Yann E. MORIN
2019-10-06 15:14 ` Yann E. MORIN [this message]
2019-10-28 12:59 ` [Buildroot] [PATCH 1/2] package/nbd: add host-pkgconf to dependencies Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006151424.GM10860@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox