Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze
Date: Sun, 6 Oct 2019 15:26:09 +0200	[thread overview]
Message-ID: <20191006152609.4ccf2cc6@gmx.net> (raw)
In-Reply-To: <20191005233341.2a661368@windsurf.home>

Hello Thomas,

On Sat, 5 Oct 2019 23:33:41 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Thu,  3 Oct 2019 16:58:06 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > Fixes [1]:
> >
> >   In file included from double-conversion.h:42:0,
> >                    from number_decimalquantity.cpp:19:
> >   double-conversion-utils.h:120:2: error: #error Target architecture was not detected as supported by Double-Conversion.
> >    #error Target architecture was not detected as supported by Double-Conversion.
> >
> > Apply the same fix as previously for qt5base ([2], already sent upstream [3],
> > but seems to be lost while merging [4]).
> >
> > [1] http://autobuild.buildroot.net/results/24005bc54cbc742decee221fb09bca19ee70502c
> > [2] https://git.buildroot.net/buildroot/commit/?id=530668ddb709cf27aa6694e00f44cf58af858b0b
> > [3] https://github.com/google/double-conversion/issues/73
> > [4] https://github.com/google/double-conversion/commit/768a445f0c28311bf88685bf0bb990505c12fd4c
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  ...ble-conversion-enable-for-microblaze.patch | 25 +++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >  create mode 100644 package/icu/0007-double-conversion-enable-for-microblaze.patch
>
> Applied to master, thanks. Could you get back to upstream so that this
> microblaze support gets added ?

Added a comment on the buggy merge commit (see [5]), maybe will wait some days before
submitting a new pull request ;-)

Regards,
Peter


[5] https://github.com/google/double-conversion/commit/768a445f0c28311bf88685bf0bb990505c12fd4c#commitcomment-35346617

>
> Thanks!
>
> Thomas

  reply	other threads:[~2019-10-06 13:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 14:58 [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze Peter Seiderer
2019-10-05 21:33 ` Thomas Petazzoni
2019-10-06 13:26   ` Peter Seiderer [this message]
2019-10-28  9:34 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191006152609.4ccf2cc6@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox