Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/leveldb: bump version to 1.22
Date: Mon, 7 Oct 2019 22:26:26 +0200	[thread overview]
Message-ID: <20191007222626.7180e191@windsurf> (raw)
In-Reply-To: <20191006122828.23586-1-bernd.kuhls@t-online.de>

On Sun,  6 Oct 2019 14:28:28 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Upstream switched to cmake, removed patches for the old buildsystem.
> Added license hash.
> 
> Package requires gcc >= 4.8:
> https://github.com/google/leveldb/blob/master/CMakeLists.txt#L14
> 
> Removed "v" from LEVELDB_SITE to reflect current naming scheme.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Did you verify that qt5webkit was still building properly after this ?

> -define LEVELDB_INSTALL_STAGING_CMDS
> -	$(TARGET_MAKE_ENV) $(MAKE1) \
> -		INSTALL_ROOT=$(STAGING_DIR) INSTALL_PREFIX=/usr \
> -		$(LEVELDB_MAKE_ARGS) -C $(@D) install
> -	$(INSTALL) -D -m 0644 $(@D)/out-static/libmemenv.a $(STAGING_DIR)/usr/lib/libmemenv.a
> -	$(INSTALL) -D -m 0644 $(@D)/helpers/memenv/memenv.h $(STAGING_DIR)/usr/include/helpers/memenv/memenv.h

Indeed, I remember that libmemenv.a and memenv.h were explicitly
installed here because they were needed by qt5webkit, and I tested the
new 1.22 version of leveldb with its CMake based build system, and it
doesn't install those files.

Also, could you verify that minetest still builds fine with this
version of leveldb ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-10-07 20:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-06 12:28 [Buildroot] [PATCH 1/1] package/leveldb: bump version to 1.22 Bernd Kuhls
2019-10-07 20:26 ` Thomas Petazzoni [this message]
2019-10-12 13:01   ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007222626.7180e191@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox