From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs/minnowboard_max-graphical: fix build due to missing glxproto.h
Date: Sat, 12 Oct 2019 16:16:58 +0200 [thread overview]
Message-ID: <20191012161658.15f8c0fd@windsurf> (raw)
In-Reply-To: <20191012135105.26722-1-unixmania@gmail.com>
Hello Carlos,
On Sat, 12 Oct 2019 10:51:05 -0300
unixmania at gmail.com wrote:
> From: Carlos Santos <unixmania@gmail.com>
>
> Commit 5cb821d5635 added a new option to enable GLX support in mesa3d.
> Update the defconfig accordingly.
>
> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/318105208
>
> Signed-off-by: Carlos Santos <unixmania@gmail.com>
> ---
> The defconfig was edited by hand to reduce the turmoild that would
> result from using "make savedefconfig"
Fixing the defconfig is not the way to go: if a given configuration
causes a build failure, then Buildroot needs to be fixed, as it means
that the mesa3d package itself is broken: it lets users create
configurations that fail to build.
For example, it means the random configuration testing from the
autobuilders could still fall into this build failure.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-12 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 13:51 [Buildroot] [PATCH] configs/minnowboard_max-graphical: fix build due to missing glxproto.h unixmania at gmail.com
2019-10-12 14:16 ` Thomas Petazzoni [this message]
2019-10-12 14:42 ` Carlos Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012161658.15f8c0fd@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox