Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH 2/4] ti-sgx-*: bump to latest TI version
Date: Wed, 16 Oct 2019 09:28:42 +0200	[thread overview]
Message-ID: <20191016092842.0092549c@windsurf> (raw)
In-Reply-To: <20191015213101.27460-2-lothar.felten@gmail.com>

Hello,

On Tue, 15 Oct 2019 23:30:59 +0200
Lothar Felten <lothar.felten@gmail.com> wrote:

> bump the ti-sgx-km,-um and -demos to the TI version that matches
> the TI SDK 06.00.00.07.
> 
> Removed all targets except AM335x.

Are you sure about this ? I've briefly browsed through the commits
2b7523d07a13ab704a24a7664749551f4a13ed32..4519ed3b83d1d72207ddc2874c7eb5e5a7f20d8d
in ti-sgx-km, and I don't see anything about removing support for
platforms.

However indeed there used to be a per-platform directory in
eurasia_km/eurasiacon/build/linux2/:

omap437x_linux
omap5430_linux
omap335x_linux
omap4430_linux

But it has now been replaced by a single folder omap_linux, in commit
5f8570e190b37e534c9195728812190ec999c9d5, which says:

commit 5f8570e190b37e534c9195728812190ec999c9d5
Author: Eric Ruei <e-ruei1@ti.com>
Date:   Fri Feb 22 12:42:58 2019 -0500

    km: Makefile cleanup
    
    This patch simplifies the omap makefile to improve readability.
    The makefile is used to build DRM-based SGX user modules for K4.x and
    AM3/4/5/6 SoC only and therefore there is no need to keep the unused
    environment variables and conditions in history.
    - Remove unsupported targets
    - Remove unused environment variables
    - Remove unused and/or dead conditions
    
    Signed-off-by: Eric Ruei <e-ruei1@ti.com>

There are still tests for various TARGET_PRODUCT values:

eurasia_km/eurasiacon/build/linux2/omap_linux/Makefile:ifneq ($(filter omap5uevm jacinto6evm,$(TARGET_PRODUCT)),)
eurasia_km/eurasiacon/build/linux2/omap_linux/Makefile:ifneq ($(filter ti654x,$(TARGET_PRODUCT)),)
eurasia_km/eurasiacon/build/linux2/omap_linux/Makefile:ifneq ($(filter ti335x ti437x,$(TARGET_PRODUCT)),)
eurasia_km/eurasiacon/build/linux2/omap_linux/Makefile: ifeq ($(TARGET_PRODUCT), ti437x)

Could you clarify why you think there is only support for AM335x left ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-10-16  7:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 21:30 [Buildroot] [RFC PATCH 1/4] new package: ti-sgx/ti-sgx-libgbm libgbm for SGX graphics accelerator Lothar Felten
2019-10-15 21:30 ` [Buildroot] [RFC PATCH 2/4] ti-sgx-*: bump to latest TI version Lothar Felten
2019-10-15 22:55   ` Arnout Vandecappelle
2019-10-16  7:28   ` Thomas Petazzoni [this message]
2019-10-16 17:57     ` Lothar Felten
2019-10-15 21:31 ` [Buildroot] [RFC PATCH 3/4] configs/beaglebone_qt5: bump kernel and uboot version, add weston Lothar Felten
2019-10-15 21:31 ` [Buildroot] [RFC PATCH 4/4] package/qt5/qt5base: support ti-sgx-libgbm Lothar Felten
2019-10-15 23:00   ` Arnout Vandecappelle
2019-10-16  7:31     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016092842.0092549c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox