Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libwebsockets: fix static build with openssl
Date: Wed, 16 Oct 2019 23:10:08 +0200	[thread overview]
Message-ID: <20191016231008.41fa8287@windsurf.home> (raw)
In-Reply-To: <CAPi7W804=Ba=kUBRQ7EhZuKf=ypAnyaPoWFMXv1F6EzLw=fqng@mail.gmail.com>

On Wed, 16 Oct 2019 23:08:34 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > > +             if (NOT LWS_WITH_ESP32)
> > > ++                    find_package(PkgConfig QUIET)
> > > ++                    pkg_check_modules(PC_OPENSSL openssl QUIET)
> > > +                     find_package(OpenSSL REQUIRED)  
> >
> > Isn't the find_package() then redundant with pkg_check_modules() ?  
> I don't think upstream will accept to add a mandatory dependency on
> pkg-config so I'll have to keep find_package as fallback.
> Moreover, CMakeLists.txt sets OPENSSL_INCLUDE_DIRS to
> OPENSSL_INCLUDE_DIR so I'll also have to update this line as
> OPENSSL_INCLUDE_DIR won't be set by pkg_check_modules.
> I think we should wait for the upstream's review.

Then:

	find_package(PkgConfig QUIET)
	if(whatever is the right way to check if pkg-config was found)
          pkg_check_modules(PC_OPENSSL openssl QUIET)
          ... adjust LIBS/CFLAGS ...
        else()
          find_package(OpenSSL REQUIRED)
        endif()

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-10-16 21:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 20:41 [Buildroot] [PATCH 1/1] package/libwebsockets: fix static build with openssl Fabrice Fontaine
2019-10-16 20:48 ` Thomas Petazzoni
2019-10-16 21:08   ` Fabrice Fontaine
2019-10-16 21:10     ` Thomas Petazzoni [this message]
2019-10-17 16:57       ` Fabrice Fontaine
2019-10-18  6:54         ` Thomas Petazzoni
2019-10-21 20:01 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016231008.41fa8287@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox