From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/kmod: fix build with python 3.8
Date: Mon, 21 Oct 2019 21:23:26 +0200 [thread overview]
Message-ID: <20191021212326.5bd4642d@windsurf> (raw)
In-Reply-To: <CADvTj4rAdZzCi5u2qBeGqjyiWPVM92TeNsBXPDRiY7ZmptLLag@mail.gmail.com>
On Mon, 21 Oct 2019 21:12:44 +0200
James Hilliard <james.hilliard1@gmail.com> wrote:
> > Reading this, I am not sure your fix is correct (though I am not sure
> > what the correct fix is).
> Yeah, not entirely sure but I saw other projects use this same fix effectively.
Yes, it "works", but it's quite weird, because the whole point of
Victor Stinner's work was to make sure Python extensions were not
linked with libpython.
> > What do you think ?
> Yeah, it's not very clear, this fix is the same as these essentially however:
> https://gitlab.freedesktop.org/gstreamer/gst-python/merge_requests/14/diffs
This is indeed a Python binding.
> https://gitlab.com/ita1024/waf/merge_requests/2236/diffs
This is a generic build system, and it only adds --embed when the
"pyembed" flag is used. It could simply be that this flag is used for
applications/libraries than embed Python, and not for Python
extensions. Indeed, the original entry in the Python issue tracker
mentioned that waf had "pyext" for Python extensions and "pyembed" for
apps/libs embedding Python.
It turns out that Victor Stinner (the author of the changes) is a
former colleague of mine from university times. I'll try to get some
feedback from him about this.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-21 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 19:38 [Buildroot] [PATCH 1/1] package/kmod: fix build with python 3.8 James Hilliard
2019-10-21 18:56 ` Thomas Petazzoni
2019-10-21 19:12 ` James Hilliard
2019-10-21 19:23 ` Thomas Petazzoni [this message]
2019-10-22 9:02 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2019-11-16 11:45 Fabrice Fontaine
2019-11-16 16:23 ` Yann E. MORIN
2019-11-16 16:35 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021212326.5bd4642d@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox