From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/valijson: bump version to 0.2
Date: Tue, 22 Oct 2019 21:36:31 +0200 [thread overview]
Message-ID: <20191022213631.0c75a174@windsurf> (raw)
In-Reply-To: <1571741515-11901-1-git-send-email-santosh.multhalli@rockwellcollins.com>
Hello Santosh,
On Tue, 22 Oct 2019 16:21:55 +0530
Santosh Multhalli <santosh.multhalli@rockwellcollins.com> wrote:
> --------
These signs are not needed.
>
> 1) Added hash of LICENSE file in valijson.hash
> 2) Updated hash of valijson tar file in valijson.hash file
> 3) Added libcurlpp dependency in valijson.mk file
> 4) Update Config.in file to select curlpp in case valijson selected
>
> --------
These are also not needed.
> diff --git a/package/valijson/Config.in b/package/valijson/Config.in
> index 10721b3..36a19c3 100644
> --- a/package/valijson/Config.in
> +++ b/package/valijson/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_VALIJSON
> depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_BOOST
> select BR2_PACKAGE_BOOST_REGEX
> + select BR2_PACKAGE_CURLPP
Are you sure curlpp is mandatory? As far as I can see, it's only used
for building some of the examples, and the examples are not built by
default.
Could you check this ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-22 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 10:51 [Buildroot] [PATCH 1/1] package/valijson: bump version to 0.2 Santosh Multhalli
2019-10-22 19:36 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-21 6:37 Santosh Multhalli
2019-10-21 12:59 ` Matthew Weber
2019-10-21 17:02 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022213631.0c75a174@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox