Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/sysrepo: fix host/staging install steps
Date: Mon, 4 Nov 2019 22:38:48 +0100	[thread overview]
Message-ID: <20191104223848.5e67d301@windsurf.home> (raw)
In-Reply-To: <20191103060113.4884-1-heiko.thiery@gmail.com>

On Sun,  3 Nov 2019 07:01:14 +0100
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> From: Heiko Thiery <heiko.thiery@kontron.com>
> 
> The sysrepoctl and sysrepocfg executables are used in install steps
> of the package. Since there are hard-coded install pathes,
> this leeds to wrong installation directories in host and staging
> install steps.
> 
> Only sysrepoctl and sysrepocfg executables are needed from host build.
> So build and install only the executables in this step.

So far, ok.

> The staging step only needs to install the library with the
> corresponding files like the headers and the pkg-config.

I don't understand this however. Is there a problem with keeping a
simple "make install" for the staging installation ? After all, for
TARGET_DIR, you've kept the default "make install" behavior, so it
should be fine for staging as well. Could you comment on this ?

Also does this commit fix any autobuilder failure ? If it does, then
please add a reference to it, like this:

Fixes:

   http://autobuild.buildroot.net/results/bcd9bdd3bc83c1f2ab0b24348d51de27d88649b4/

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-11-04 21:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03  6:01 [Buildroot] [PATCH 1/1] package/sysrepo: fix host/staging install steps Heiko Thiery
2019-11-04 21:38 ` Thomas Petazzoni [this message]
2019-11-05  8:03   ` Heiko Thiery
2019-11-05  8:09     ` Thomas Petazzoni
2019-11-05  8:19       ` Heiko Thiery
2019-11-08 21:58 ` Thomas Petazzoni
2019-11-10 16:00   ` Heiko Thiery
2019-11-11 13:53     ` Thomas Petazzoni
2019-11-11 14:07       ` Heiko Thiery
2019-11-11 14:27         ` Thomas Petazzoni
2019-11-11 14:35           ` Heiko Thiery
2019-11-11 14:40             ` Thomas Petazzoni
2019-11-11 14:43               ` Heiko Thiery
2019-11-11 14:59                 ` Thomas Petazzoni
2019-11-11 15:04                   ` Heiko Thiery
2019-11-11 15:12                     ` Thomas Petazzoni
2019-11-11 19:22                       ` Heiko Thiery
2019-11-12  7:53                         ` Heiko Thiery
2019-11-17  5:32                           ` Heiko Thiery
2019-12-02  8:15                             ` Heiko Thiery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104223848.5e67d301@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox