Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jemy.zhang at gmail.com <jemy.zhang@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] fix corrupted download url of extra packages
Date: Tue,  5 Nov 2019 17:04:48 +0800	[thread overview]
Message-ID: <20191105090448.99235-2-jemy.zhang@gmail.com> (raw)
In-Reply-To: <20191105090448.99235-1-jemy.zhang@gmail.com>

From: "Jemy Zhang" <jemy.zhang@gmail.com>

If the download url of extra packages contains '+', the contents before
'+' will be parsed as SITE_METHOD, the original download url corrupted.

check with android-tools package.

Signed-off-by: Jemy Zhang <jemy.zhang@gmail.com>
---
 package/pkg-generic.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 893faba22a..bb0ca939a3 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -523,8 +523,9 @@ endif
 $(2)_ALL_DOWNLOADS = \
 	$$(if $$($(2)_SOURCE),$$($(2)_SITE_METHOD)+$$($(2)_SITE)/$$($(2)_SOURCE)) \
 	$$(foreach p,$$($(2)_PATCH) $$($(2)_EXTRA_DOWNLOADS),\
-		$$(if $$(findstring ://,$$(p)),$$(p),\
-			$$($(2)_SITE)/$$(p)))
+		$$(call getschemeplusuri,$$(call qstrip,\
+		  $$(if $$(findstring ://,$$(p)),$$(p),\
+			  $$($(2)_SITE)/$$(p))),urlencode))
 
 ifndef $(2)_SITE
  ifdef $(3)_SITE
-- 
2.22.0

  reply	other threads:[~2019-11-05  9:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  9:04 [Buildroot] [PATCH 0/1] download url broken if url include '+' jemy.zhang at gmail.com
2019-11-05  9:04 ` jemy.zhang at gmail.com [this message]
2019-11-08 17:28   ` [Buildroot] [PATCH 1/1] fix corrupted download url of extra packages Yann E. MORIN
2019-11-08 22:26     ` jemy zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105090448.99235-2-jemy.zhang@gmail.com \
    --to=jemy.zhang@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox