Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Include makefiles from GLOBAL_PATCH_DIR
Date: Thu, 7 Nov 2019 19:15:13 +0100	[thread overview]
Message-ID: <20191107181513.GD3419@scaer> (raw)
In-Reply-To: <20191107180958.GC3419@scaer>

All,

On 2019-11-07 19:09 +0100, Yann E. MORIN spake thusly:
> On 2019-11-06 23:31 +0100, Thomas Petazzoni spake thusly:
> > On Wed, 6 Nov 2019 17:37:48 +0100
> > "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> [--SNIP--]
> > > So, I am afraid that these overrides are a poor excuse for not wanting to
> > > do actual VCS work.
> > Well, you are the one who introduced BR2_EXTERNAL in the first place!
> 
> Ahem... git show a4239f7fd10 ;-)
> 
> I did introduce support for multi br2-external, though.
> 
> Anyway, this patch, as on IRC by J?r?my, has a designe flaw: since the

*as discussed on IRC with ... a design flaw...

> override files are included too early, they hcamge the way pkgdir is

* change

> computed, and this breaks completely.
> 
> This can be corrected, though, and it might even not be too complex to
> do.
> 
> But if we're going to do the override stuff, I think we must think it
> thouroughly, and not use an half-baked solution.
> 
> If at all, I'd favour looking at the aternate solution that was floated
> around during the last devdays: postpone evaluation of the infras to
> after all the packages hav actually been scanned. This would even allow
> overriding the type of a package (e.g. autotools-package instead of
> meson-package, in case the version was changed to use another
> buildsystem).

... and thus we could drop the check that a package is not redefined,
and so a package could be redefined in a br2-external tree, and that
would not need any new override mechanism at all, presumably.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2019-11-07 18:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26 14:51 [Buildroot] [PATCH 1/1] Include makefiles from GLOBAL_PATCH_DIR Jérémy Rosen
2019-11-06 16:37 ` Yann E. MORIN
2019-11-06 20:07   ` Jérémy ROSEN
2019-11-06 22:31   ` Thomas Petazzoni
2019-11-06 22:41     ` Vadim Kochan
2019-11-07 18:09     ` Yann E. MORIN
2019-11-07 18:15       ` Yann E. MORIN [this message]
2019-11-07 21:47         ` Jérémy ROSEN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107181513.GD3419@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox