From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/zxing-cpp: fix build with cppunit and gcc 5
Date: Sat, 9 Nov 2019 09:51:01 +0100 [thread overview]
Message-ID: <20191109085101.GN3419@scaer> (raw)
In-Reply-To: <20191109083710.10660-2-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2019-11-09 09:37 +0100, Fabrice Fontaine spake thusly:
> Fixes:
> - http://autobuild.buildroot.org/results/8c675300aa7e7f2a5a2f0a2ac0f191b8d2ff8c42
This should be folded in the previous patch, as this is mostly the same
thing: adding the optional dependency on cppunit and fixing the build
with cppunit.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
[--SNIP--]
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index ccb2ba9..738f4e1 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -34,6 +34,8 @@ include(source_files.cmake)
> + add_definitions(-D_CRT_SECURE_NO_WARNINGS)
> + add_definitions(/Za)
> + endif()
> ++
> ++set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
This hints that maybe a dependency on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 is
now needed, no?
Regards,
Yann E. MORIN.
> + # Add libzxing library.
> + file(GLOB_RECURSE LIBZXING_FILES
> --
> 2.23.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2019-11-09 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 8:37 [Buildroot] [PATCH 1/2] package/zxing-cpp: add optional cppunit dependency Fabrice Fontaine
2019-11-09 8:37 ` [Buildroot] [PATCH 2/2] package/zxing-cpp: fix build with cppunit and gcc 5 Fabrice Fontaine
2019-11-09 8:51 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109085101.GN3419@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox