From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/gcnano-binaries: new package
Date: Mon, 11 Nov 2019 14:16:09 +0100 [thread overview]
Message-ID: <20191111141609.757023f1@windsurf> (raw)
In-Reply-To: <trinity-5b74f91d-c30f-42b7-9c54-1a49e1f58aee-1573467571744@3c-app-webde-bs25>
Hello Jens,
On Mon, 11 Nov 2019 11:19:31 +0100
"Jens Kleintje" <Scooby22@web.de> wrote:
> > Please use the "github" helper macro:
>
> > GCNANO_BINARIES_VERSION = c01642ed5e18cf09ecd905af193e935cb3be95ed
> > GCNANO_BINARIES_SITE = $(call github,STMicroelectronics,gcnano-binaries,$(GCNANO_BINARIES_VERSION))
>
> > and remove the _SITE_METHOD variable.
> The page (https://github.com/STMicroelectronics/gcnano-binaries)
> has no release and no tag. So I think there is no archive directory.
Not a problem, the github macro works with any arbitrary commit.
> > > + rm -f $(STAGING_DIR)/usr/lib/pkgconfig/wayland-egl.pc
>
> > Why are you removing this .pc file ?
> The file is already provided by wayland package.
> I saw it from in the yocto package
> https://github.com/STMicroelectronics/meta-st-stm32mp/blob/thud/recipes-graphics/gcnano-userland/gcnano-userland-binary.inc
Then, if you could add a comment in the .mk file about this, it would
be good.
> > Could you rework your patch to take into account those comments ?
> Will come soon.
Great, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-11 13:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 15:56 [Buildroot] [PATCH 0/2] package/gcnano-binaries: new package Jens Kleintje
2019-11-06 15:56 ` [Buildroot] [PATCH 1/2] " Jens Kleintje
2019-11-06 22:08 ` Thomas Petazzoni
[not found] ` <trinity-e5303488-a97e-46bb-8738-520846b1c6db-1573110060239@3c-app-webde-bap18>
2019-11-11 10:19 ` Jens Kleintje
2019-11-11 13:16 ` Thomas Petazzoni [this message]
2019-11-11 13:48 ` Jens Kleintje
2019-11-11 13:55 ` Thomas Petazzoni
2019-11-11 13:58 ` Jens Kleintje
2019-11-06 15:56 ` [Buildroot] [PATCH 2/2] package/qt5/qt5base: add support for gcnano-binaries Jens Kleintje
2019-11-06 22:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111141609.757023f1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox