[Buildroot] [PATCH] package/x11r7/xserver_xorg-server: Fix ARM build

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Thomas,

On Mon, 11 Nov 2019 12:48:07 +0000
Thomas Preston <thomas.preston@codethink.co.uk> wrote:

> The ARM sys/io.h has been removed from upstream glibc, which is in
> buildroot. This causes the xorg-server build to fail on ARM when using
> the glibc toolchain.
> 
> The following patches from upstream xserver fix this, but have not yet
> been released.
> 
> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>

Do we have any autobuilder failures for this? From a quick look, I
don't see any. So the question is: why?

> diff --git a/package/x11r7/xserver_xorg-server/1.20.5/0006-compiler.h-only-use-inx-outx-on-ARM-with-glibc.patch b/package/x11r7/xserver_xorg-server/1.20.5/0006-compiler.h-only-use-inx-outx-on-ARM-with-glibc.patch
> new file mode 100644
> index 0000000000..f1b27d7484
> --- /dev/null
> +++ b/package/x11r7/xserver_xorg-server/1.20.5/0006-compiler.h-only-use-inx-outx-on-ARM-with-glibc.patch
> @@ -0,0 +1,32 @@
> +From 6a2ce6c5da9456b97683db6224f38ef3b02cce4b Mon Sep 17 00:00:00 2001
> +From: Ross Burton <ross.burton@intel.com>
> +Date: Thu, 20 Sep 2018 13:21:34 +0100
> +Subject: [PATCH 1/2] compiler.h: only use inx/outx on ARM with glibc

Use "git format-patch -N" when generating patches, so that we don't
have the "PATCH 1/2" prefix, but just "PATCH". Indeed PATCH 1/2 for a
patch labeled 0006-something is a bit useless.

> +
> +musl only implements inx/outx on x86, so check for __GLIBC__ instead of
> +__linux__.
> +
> +Signed-off-by: Ross Burton <ross.burton@intel.com>

But this commit doesn't seem at all related to the glibc failure, it
would rather be useful to fix a build issue against the musl C library.
I also don't see such build failures in our autobuilders. Why?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com