Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] package/sdbusplus: new package
Date: Wed, 13 Nov 2019 14:02:05 +0100	[thread overview]
Message-ID: <20191113140205.03121bcb@windsurf> (raw)
In-Reply-To: <20190807191146.32047-1-jfaith@impinj.com>

Hello John,

On Wed, 7 Aug 2019 19:12:00 +0000
John Faith <jfaith@impinj.com> wrote:

> A C++ library for interacting with sd-bus and a C++ bindings generator.
> 
> The host build produces a code generation tool, sdbus++ while the
> target build gives libsdbusplus.
> 
> The code generator requires host-python-pyyaml, host-python-inflection,
> and host-python-mako. Since it isn't built for the target, the target
> build does not require them.
> 
> The host package includes a code and documentation generation program,
> which is useful for including in a buildroot SDK, even if no target
> package needs it, so make it a user-selectable host package.
> 
> host-autoconf-archive is added as a dependency since configure.ac
> uses the AX_PKG_CHECK_MODULES macro.
> 
> Signed-off-by: John Faith <jfaith@impinj.com>
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>

I have finally applied to next, with one change. See below.

> +SDBUSPLUS_VERSION = 4212292bcf136d04b38ba5116aa568b0fa312798
> +SDBUSPLUS_SITE = $(call github,openbmc,sdbusplus,$(SDBUSPLUS_VERSION))
> +SDBUSPLUS_DEPENDENCIES = host-autoconf-archive host-pkgconf systemd
> +HOST_SDBUSPLUS_DEPENDENCIES = \
> +	host-autoconf-archive \
> +	host-pkgconf \
> +	host-python \

I replaced this with:

	$(if $(BR2_PACKAGE_PYTHON3),host-python3,host-python)

which is something we do in many other packages, to use host-python3
when host-python3 is anyway going to be built as a dependency of the
target python3.

I tested it, and it does seem to work, i.e I was able to use the
binding generator tool with a Python 3 installation.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-11-13 13:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 20:43 [Buildroot] [PATCH v2 0/1] package/sdbusplus: new package John Faith
2019-07-02 20:43 ` [Buildroot] [PATCH v2 1/1] " John Faith
2019-07-11 14:21   ` Arnout Vandecappelle
2019-07-19 20:18     ` Trent Piepho
2019-08-05 22:52     ` [Buildroot] [PATCH v3] " John Faith
2019-08-06 21:10       ` Thomas Petazzoni
2019-08-07 18:51         ` John Faith
2019-08-07 19:12     ` [Buildroot] [PATCH v4] " John Faith
2019-11-13 13:02       ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113140205.03121bcb@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox