From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 05/11] package/kodi: drop readline dependency
Date: Wed, 13 Nov 2019 22:26:27 +0100 [thread overview]
Message-ID: <20191113212627.GU3419@scaer> (raw)
In-Reply-To: <20191113151724.12155-6-peter@korsgaard.com>
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
> {python-,}readline is (no longer) a required dependency of kodi, and
> readline (GPL-3.0+) is not license compatible with kodi (GPL-2.0), so drop
> the dependency.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
[--SNIP--]
> diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
> index 028bf551bc..49728e464b 100644
> --- a/package/kodi/kodi.mk
> +++ b/package/kodi/kodi.mk
> @@ -38,7 +38,6 @@ KODI_DEPENDENCIES = \
> openssl \
> pcre \
> python \
> - readline \
What does actually prevent kodi from linking with readline, is that
happens to be built before?
I'll kick-start a build here (without your patch) and see what goes
linked with readline, if anything.
In the meantime, I've pondered applying this patch anyway, because it
removes the explicit dependency, so that if kodi still links to
readline, that would be an accident due to another intermediate
dependency, and thus not our fault. But I am not too happy either, so
I refrained eventually...
Regards,
Yann E. MORIN.
> sqlite \
> taglib \
> tinyxml \
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-11-13 21:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 15:17 [Buildroot] [PATCH 00/11] Fix license incompatibility with readline Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 01/11] package/chrony: use libedit for command line editing Peter Korsgaard
2019-11-13 18:53 ` Yann E. MORIN
2019-11-13 19:14 ` Peter Korsgaard
2019-11-13 20:10 ` Yann E. MORIN
2019-11-18 13:17 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 02/11] package/connman: clarify license of client code Peter Korsgaard
2019-11-13 18:56 ` Yann E. MORIN
2019-11-17 16:03 ` Arnout Vandecappelle
2019-11-18 13:02 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 03/11] package/dropwatch: license is GPL-2.0+ Peter Korsgaard
2019-11-13 16:19 ` Baruch Siach
2019-11-13 19:15 ` Peter Korsgaard
2019-11-13 19:00 ` Yann E. MORIN
2019-11-18 13:08 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 04/11] package/ipsec-tools: add license information Peter Korsgaard
2019-11-13 21:27 ` Yann E. MORIN
2019-11-19 7:39 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 05/11] package/kodi: drop readline dependency Peter Korsgaard
2019-11-13 21:26 ` Yann E. MORIN [this message]
2019-11-14 17:37 ` Yann E. MORIN
2019-11-14 5:44 ` Bernd Kuhls
2019-11-19 7:57 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 06/11] package/kodi: add hash for license file Peter Korsgaard
2019-11-13 20:39 ` Yann E. MORIN
2019-11-19 7:39 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 07/11] package/lvm2: drop optional readline dependency Peter Korsgaard
2019-11-13 21:00 ` Yann E. MORIN
2019-11-19 7:39 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 08/11] package/mariadb: use bundled GPL-2.0+ libreadline Peter Korsgaard
2019-11-13 21:00 ` Yann E. MORIN
2019-11-19 7:39 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 09/11] package/neardal: unconditionally use libedit Peter Korsgaard
2019-11-13 20:58 ` Yann E. MORIN
2019-11-14 8:23 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 10/11] package/oracle-mysql: use bundled GPL-2.0+ libreadline Peter Korsgaard
2019-11-13 21:08 ` Yann E. MORIN
2019-11-19 7:54 ` Peter Korsgaard
2019-11-13 15:17 ` [Buildroot] [PATCH 11/11] package/socat: drop optional readline dependency Peter Korsgaard
2019-11-13 16:15 ` Baruch Siach
2019-11-13 21:02 ` Yann E. MORIN
2019-11-19 7:39 ` Peter Korsgaard
2019-11-13 21:13 ` [Buildroot] [PATCH 00/11] Fix license incompatibility with readline Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113212627.GU3419@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox