From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/neardal: unconditionally use libedit
Date: Thu, 14 Nov 2019 22:20:12 +0100 [thread overview]
Message-ID: <20191114212013.29398-2-peter@korsgaard.com> (raw)
In-Reply-To: <20191114212013.29398-1-peter@korsgaard.com>
neardal is licensed under LGPL-2.0, which is (most likely) not license
compatible with readline (GPL-3.0+), so always use the libedit backend.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/neardal/Config.in | 2 +-
package/neardal/neardal.mk | 10 +---------
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/package/neardal/Config.in b/package/neardal/Config.in
index c729283380..5f33ae4953 100644
--- a/package/neardal/Config.in
+++ b/package/neardal/Config.in
@@ -5,7 +5,7 @@ config BR2_PACKAGE_NEARDAL
depends on BR2_USE_MMU # dbus
select BR2_PACKAGE_DBUS
select BR2_PACKAGE_DBUS_GLIB
- select BR2_PACKAGE_READLINE if !BR2_PACKAGE_LIBEDIT
+ select BR2_PACKAGE_LIBEDIT
help
Provides a simple C API to exchange data with the neard NFC
manager daemon.
diff --git a/package/neardal/neardal.mk b/package/neardal/neardal.mk
index b56ce3b3a3..28e2850e30 100644
--- a/package/neardal/neardal.mk
+++ b/package/neardal/neardal.mk
@@ -10,17 +10,9 @@ NEARDAL_INSTALL_STAGING = YES
NEARDAL_LICENSE = LGPL-2.0
NEARDAL_LICENSE_FILES = COPYING
-NEARDAL_DEPENDENCIES = host-pkgconf dbus dbus-glib
+NEARDAL_DEPENDENCIES = host-pkgconf dbus dbus-glib libedit
NEARDAL_AUTORECONF = YES
-# Either readline or libedit are needed, and the Config.in file
-# guarantees at least one of them is enabled
-ifeq ($(BR2_PACKAGE_READLINE),y)
-NEARDAL_DEPENDENCIES += readline
-else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
-NEARDAL_DEPENDENCIES += libedit
-endif
-
define NEARDAL_INSTALL_NCL
$(INSTALL) -m 0755 -D $(@D)/ncl/ncl $(TARGET_DIR)/usr/bin/ncl
endef
--
2.20.1
next prev parent reply other threads:[~2019-11-14 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 21:20 [Buildroot] [PATCH 1/2] package/neardal: license is LGPL-2.0, not GPL-2.0 Peter Korsgaard
2019-11-14 21:20 ` Peter Korsgaard [this message]
2019-11-14 21:55 ` [Buildroot] [PATCH 2/2] package/neardal: unconditionally use libedit Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114212013.29398-2-peter@korsgaard.com \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox