From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/ltp-testsuite: proper fix for missing __kernel_fsid_t
Date: Fri, 15 Nov 2019 20:31:18 +0100 [thread overview]
Message-ID: <20191115193118.GA19966@x230> (raw)
In-Reply-To: <20191114213050.GF26360@scaer>
Hi Yann,
> On 2019-11-14 21:02 +0100, Petr Vorel spake thusly:
> > Backported 3 fixes from upstream (2 of them require calling autoreconf.
> > Fixes: http://autobuild.buildroot.net/results/7a29e3b767e3d23dd64c130daa735ca6c062baf8
> Sorry, but that does not seem to be enough to properly fix the build
> above. I got this when testing locally:
> In file included from fanotify13.c:28:
> fanotify13.c: In function ?setup_marks?:
> fanotify.h:147:41: error: ?lapi_fsid_t? {aka ?struct <anonymous>?} has no member named ?__val?; did you mean ?val??
> # define FSID_VAL_MEMBER(fsid, i) (fsid.__val[i])
> ^~~~~
> fanotify13.c:133:7: note: in expansion of macro ?FSID_VAL_MEMBER?
> !FSID_VAL_MEMBER(event_set[i].fsid, 0) &&
> ^~~~~~~~~~~~~~~
> fanotify.h:147:41: error: ?lapi_fsid_t? {aka ?struct <anonymous>?} has no member named ?__val?; did you mean ?val??
> # define FSID_VAL_MEMBER(fsid, i) (fsid.__val[i])
> ^~~~~
> fanotify13.c:134:7: note: in expansion of macro ?FSID_VAL_MEMBER?
> !FSID_VAL_MEMBER(event_set[i].fsid, 1)) {
> ^~~~~~~~~~~~~~~
> If you look carefully, I have the exact inverse problem as reported in
> one of the patches, below: confusion between 'val' and '__val'...
Musl config which works:
* /home/pevik/br-test-pkg/br-x86-64-musl/.config
BR2_DEFCONFIG="$(CONFIG_DIR)/defconfig"
BR2_TOOLCHAIN_USES_MUSL=y
BR2_TOOLCHAIN_EXTERNAL_MUSL=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-x86-64-musl-2019.05.1.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_CUSTOM_MUSL=y
BR2_PACKAGE_MUSL_COMPAT_HEADERS=y
BR2_PACKAGE_MUSL_FTS=y
# BR2_TOOLCHAIN_EXTERNAL_MUSL_CROSS is not set
Broken one (
* pc_x86_64_bios_defconfig, libc changed to musl
BR2_DEFCONFIG="/home/pevik/install/src/buildroot.git/configs/pc_x86_64_bios_defconfig"
BR2_TOOLCHAIN_USES_MUSL=y
BR2_TOOLCHAIN_BUILDROOT_MUSL=y
BR2_TOOLCHAIN_BUILDROOT_LIBC="musl"
BR2_PACKAGE_MUSL=y
BR2_PACKAGE_MUSL_COMPAT_HEADERS=y
BR2_PACKAGE_MUSL_FTS=y
# BR2_TOOLCHAIN_EXTERNAL_MUSL_CROSS is not set
There are more differences in these 2 configs, but I bet this
BR2_TOOLCHAIN_BUILDROOT_MUSL=y vs. BR2_TOOLCHAIN_EXTERNAL_MUSL=y can be
the difference.
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-15 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 20:02 [Buildroot] [PATCH v2 1/1] package/ltp-testsuite: proper fix for missing __kernel_fsid_t Petr Vorel
2019-11-14 20:20 ` Petr Vorel
2019-11-14 21:30 ` Yann E. MORIN
2019-11-15 7:07 ` Petr Vorel
2019-11-15 19:31 ` Petr Vorel [this message]
2019-11-15 20:19 ` Petr Vorel
2019-11-15 20:54 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115193118.GA19966@x230 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox