Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] package/spice: add optional gdk-pixbuf dependency
Date: Fri, 15 Nov 2019 21:20:29 +0100	[thread overview]
Message-ID: <20191115202029.GH26360@scaer> (raw)
In-Reply-To: <20191114191321.11789-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2019-11-14 20:13 +0100, Fabrice Fontaine spake thusly:
> This dependency has been added in version 0.14.1 with
> https://gitlab.freedesktop.org/spice/spice-common/commit/d58a5b6a5a25134396661e1d805dfc567181e3af
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/spice/spice.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/spice/spice.mk b/package/spice/spice.mk
> index 16e57441a8..f5801ce0ff 100644
> --- a/package/spice/spice.mk
> +++ b/package/spice/spice.mk
> @@ -13,6 +13,7 @@ SPICE_INSTALL_STAGING = YES
>  SPICE_DEPENDENCIES = \
>  	host-pkgconf \
>  	jpeg \
> +	$(if $(BR2_PACKAGE_GDK_PIXBUF),gdk-pixbuf) \

I see you've gine for conciseness here. However, I think we want to
handle this optional dependency like we handle the optional dependency
on opus, lines 53..56.

Regards,
Yann E. MORIN.

>  	libglib2 \
>  	openssl \
>  	pixman \
> -- 
> 2.23.0
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2019-11-15 20:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 19:13 [Buildroot] [PATCH 1/5] package/spice: add optional gdk-pixbuf dependency Fabrice Fontaine
2019-11-14 19:13 ` [Buildroot] [PATCH 2/5] package/gdk-pixbuf: add gio to Requires.private Fabrice Fontaine
2019-11-18 22:23   ` Thomas Petazzoni
2019-11-14 19:13 ` [Buildroot] [PATCH 3/5] package/spice: needs dynamic library Fabrice Fontaine
2019-11-14 19:13 ` [Buildroot] [PATCH 4/5] package/spice-protocol: bump to version 0.14.0 Fabrice Fontaine
2019-11-14 19:13 ` [Buildroot] [PATCH 5/5] package/spice: security bump to version 0.14.2 Fabrice Fontaine
2019-11-15 20:20 ` Yann E. MORIN [this message]
2019-11-15 20:27   ` [Buildroot] [PATCH 1/5] package/spice: add optional gdk-pixbuf dependency Fabrice Fontaine
2019-11-17 15:40     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115202029.GH26360@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox