From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 18 Nov 2019 22:47:03 +0100 Subject: [Buildroot] [PATCH v2,1/4] package/spice: disable tests In-Reply-To: <20191117164452.5361-1-fontaine.fabrice@gmail.com> References: <20191117164452.5361-1-fontaine.fabrice@gmail.com> Message-ID: <20191118224703.3fb65955@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Sun, 17 Nov 2019 17:44:49 +0100 Fabrice Fontaine wrote: > By disabling tests, we'll remove the optional gdk-pixbuf dependency > > Fixes: > - http://autobuild.buildroot.org/results/96c786f85d35f33508e9c71778043d16b87f72cd > > Signed-off-by: Fabrice Fontaine > --- > Changes v1 -> v2 (after review of Yann E. Morin): > - Disable tests instead of adding and fixing gdk-pixbuf optional > dependency I've applied to next. However, your patch to upstream is not really complete, or at least an additional patch is needed: when tests are enabled, their configure.ac script should check if gdk-pixbuf is available. And if it's not available, it should bail out, or disable tests, but not allow the configure process to complete, and then have a build failure when compiling. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com