[Buildroot] [PATCH 1/2] package/gmpc: needs -lm

[Peter Seiderer <ps.report@gmx.net>]

Hello *,

On Sun, 17 Nov 2019 21:54:38 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:

> On 17/11/2019 21:48, Peter Seiderer wrote:
> > Hello *,
> >
> > On Sun, 17 Nov 2019 21:20:01 +0100, Peter Seiderer <ps.report@gmx.net> wrote:
> >
> >> Hello Arnout,
> >>
> >> On Sun, 17 Nov 2019 20:45:19 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:
> >>
> >>> On 08/11/2019 22:28, Peter Seiderer wrote:
> >>>> Hello Fabrice, Thomas,
> >>>>
> >>>> On Fri, 8 Nov 2019 22:04:42 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> >>>>
> >>>>> On Tue, 29 Oct 2019 22:40:45 +0100
> >>>>> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> >>>>>
> >>>>>> gmpc forgets to link with -lm:
> >>>>>>
> >>>>>> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/mips-linux-gnu/5.3.0/../../../../mips-linux-gnu/bin/ld: GmpcVolume.o: undefined reference to symbol 'ceil@@GLIBC_2.0'
> >>>>>> /home/buildroot/autobuild/instance-2/output-1/host/mips64el-buildroot-linux-gnu/sysroot/soft-float/el/lib64/libm.so.6: error adding symbols: DSO missing from command line
> >>>>>>
> >>>>>> Fixes:
> >>>>>>  - http://autobuild.buildroot.org/results/a79e0487135ad90530595d5c6ecc32f9c8cea7c4
> >>>>>>
> >>>>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> >>>>>
> >>>>> We need to understand why this is happening now. This package has not
> >>>>> been modified since July 2017, but suddenly, on October 21, 2019, it
> >>>>> started failing like this. Why? Was there a change in one of the
> >>>>> dependencies, that is no longer linked with libm, and that causes this
> >>>>> problem ?
> >>>
> >>>  It started because of RELRO, I think.
> >>>
> >>>>
> >>>> Maybe the same cause/problem as in the libv4l case regarding libatomic,
> >>>> evaluating vs. not evaluationg the *.la files (see [1])?
> >>>
> >>>  And this one because of PIC_PIE.
> >>
> >> Any hints to one/more related commits (so I can check by reverting if it
> >> changes/fix the problems)?
> >>
> >> Are the RELRO/PIC_PIE options related to evaluating *.la files?
> >
> > Did a quick search by the date (October 21, 2019) and the info from the libv4l
> > case [1] and would suspect the commit 'pkgconf: Add pkgconf system lib and
> > include path' [2], will do a test with this commit reverted....
>
>  Good point. Also there's a failure without PIC_PIE or RELRO [3].

Can confirm, reverting [2] fixes the libv4l and the gmpc linking problems...

Regards,
Peter

>
>  Regards,
>  Arnout
>
> >
> > Regards,
> > Peter
> >
> > [2] https://git.buildroot.net/buildroot/commit/?id=9cc8680fe54c0b8f5008158e36e2157127f03a7e
>
> [3]
> http://autobuild.buildroot.net/results/e7f/e7f37080c20e2131613517c3007b4569c28dbcf2
>
>
> >
> >>
> >> Regards,
> >> Peter
> >>
> >>>
> >>>  Regards,
> >>>  Arnout
> >>>
> >>>>
> >>>> Regards,
> >>>> Peter
> >>>>
> >>>> [1] http://lists.busybox.net/pipermail/buildroot/2019-October/264928.html
> >>>>
> >>>>>
> >>>>> I think I already asked this in the past: when you fix an issue, don't
> >>>>> just fix the issue, but explain why the issue is happening, especially
> >>>>> in situations like these.
> >>>>>
> >>>>> Thanks!
> >>>>>
> >>>>> Thomas
> >>>>
> >>>> _______________________________________________
> >>>> buildroot mailing list
> >>>> buildroot at busybox.net
> >>>> http://lists.busybox.net/mailman/listinfo/buildroot
> >>>>
> >>> _______________________________________________
> >>> buildroot mailing list
> >>> buildroot at busybox.net
> >>> http://lists.busybox.net/mailman/listinfo/buildroot
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot at busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
> >
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot